alexcrichton opened PR #14428 from alexcrichton:start-migrating-p1-tests to bytecodealliance:main:
This commit is a migration of preexisting wasip1 tests in Wasmtime's test suite to the wasip2 target. The goal here is to lessen Wasmtime's dependence on the
wasm32-wasip1target in CI over time, but this is going to be a bit of a process. Currently all of Wasmtime's source-code-written tests are compiled forwasm32-wasip1and then componentized optionally later with the adapter. I'd like to natively compile forwasm32-wasip2eventually, but for now the goal is to shift away from p1-sourced tests.Additionally Wasmtime has very little testing of wasip2 specifically. Instead all wasip1 tests are componentized with the adapter and run both as a core module and a component. This means that the coverage for wasip2 is basically the same as wasip1, but it also means that should the tests simply be deleted we'd lose wasip2 test coverage.
That brings us to this change. Here wasip1 tests are migrated to wasip2. The tests migrated here are already duplicated in the upstream WebAssembly/wasi-testsuite repository (where many tests came from Wasmtime originally), so this additionally isn't losing coverage for wasip1 either. For now the goal of this commit is to be coverage-neutral where wasip1 tests are shifted to being tested by wasi-testsuite, and wasip2 tests are preserved by manually writing against the wasip2 APIs.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease review the Bytecode Alliance's AI tool usage policy at
https://github.com/bytecodealliance/governance/blob/main/AI_TOOL_POLICY.mdPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
alexcrichton requested rvolosatovs for a review on PR #14428.
alexcrichton requested pchickey for a review on PR #14428.
alexcrichton requested wasmtime-wasi-reviewers for a review on PR #14428.
alexcrichton requested wasmtime-core-reviewers for a review on PR #14428.
:thumbs_up: pchickey submitted PR review:
Thanks, looks good, I still think we should retain a bit of coverage for the adapter until its gone from the tree so I sent https://github.com/alexcrichton/wasmtime/pull/61 to add that in a way that is hopefully not too invasive
alexcrichton updated PR #14428.
alexcrichton updated PR #14428.
alexcrichton updated PR #14428.
alexcrichton added PR #14428 Migrate wasip1 tests to wasip2 when duplicated in wasi-testsuite to the merge queue.
:check: alexcrichton merged PR #14428.
alexcrichton removed PR #14428 Migrate wasip1 tests to wasip2 when duplicated in wasi-testsuite from the merge queue.
Last updated: Oct 11 2026 at 04:10 UTC