alexcrichton opened PR #14424 from alexcrichton:fix-flak to bytecodealliance:main:
This commit is an attempt at fixing the spurious failure that happened at https://github.com/bytecodealliance/wasmtime/actions/runs/36156707251/job/108142997495. While I don't know exactly what happened the hunch is that one thread of the process opened up a shell script for writing, another thread in the process
fork'd which then keeps the fd open for writing before anyexec`, and then the original thread tries to execute the file. This then fails because the fd is open for writing and thus can't be opened for execution.The fix here is to avoid writing something to the filesystem and fiddle with
sharguments to pass the script in differently.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease review the Bytecode Alliance's AI tool usage policy at
https://github.com/bytecodealliance/governance/blob/main/AI_TOOL_POLICY.mdPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
alexcrichton requested cfallin for a review on PR #14424.
alexcrichton requested wasmtime-compiler-reviewers for a review on PR #14424.
github-actions[bot] added the label isle on PR #14424.
github-actions[bot] added the label cranelift on PR #14424.
github-actions[bot] commented on PR #14424:
Subscribe to Label Action
cc @avanhatt, @cfallin, @fitzgen, @mmcloughlin
<details>
This issue or pull request has been labeled: "cranelift", "isle"Thus the following users have been cc'd because of the following labels:
- avanhatt: isle
- cfallin: isle
- fitzgen: isle
- mmcloughlin: isle
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
:thumbs_up: cfallin submitted PR review:
Thanks for tracking this down!
cfallin added PR #14424 Fix spurious failure testing cranelift-isle-veri-caching to the merge queue.
:check: cfallin merged PR #14424.
cfallin removed PR #14424 Fix spurious failure testing cranelift-isle-veri-caching from the merge queue.
alexcrichton edited PR #14424:
This commit is an attempt at fixing the spurious failure that happened at https://github.com/bytecodealliance/wasmtime/actions/runs/36156707251/job/108142997495. While I don't know exactly what happened the hunch is that one thread of the process opened up a shell script for writing, another thread in the process
fork'd which then keeps the fd open for writing before anyexec, and then the original thread tries to execute the file. This then fails because the fd is open for writing and thus can't be opened for execution.The fix here is to avoid writing something to the filesystem and fiddle with
sharguments to pass the script in differently.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease review the Bytecode Alliance's AI tool usage policy at
https://github.com/bytecodealliance/governance/blob/main/AI_TOOL_POLICY.mdPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Last updated: Oct 11 2026 at 04:10 UTC