Stream: git-wasmtime

Topic: wasmtime / PR #14379 winch: handle unreachable try_table ...


view this post on Zulip Wasmtime GitHub notifications bot (Sep 22 2026 at 17:11):

macovedj opened PR #14379 from macovedj:winch-unreachable-try-table to bytecodealliance:main:

Compiling a try_table after an unconditional return currently fails with Invalid local offset, and with fuel enabled fails with Invalid fuel state. The first issue arises from Winch still registering its catches and attempting to emit landing pads, even though entering an unreachable block skips recording the stack state those handlers need. The latter comes from not skipping fuel accounting for unreachable control operators.

Winch now uses a plain block frame for a try_table entered in unreachable code, preserving nesting without registering catches. It also skips fuel accounting for unreachable operators while retaining the assertion that preceding reachable code flushed its pending charges.

Fixes #14377

view this post on Zulip Wasmtime GitHub notifications bot (Sep 22 2026 at 17:11):

macovedj requested fitzgen for a review on PR #14379.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 22 2026 at 17:11):

macovedj requested wasmtime-compiler-reviewers for a review on PR #14379.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 22 2026 at 17:11):

macovedj requested wasmtime-core-reviewers for a review on PR #14379.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 22 2026 at 18:47):

github-actions[bot] added the label winch on PR #14379.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 22 2026 at 18:48):

github-actions[bot] commented on PR #14379:

Subscribe to Label Action

cc @saulecabrera

<details>
This issue or pull request has been labeled: "winch"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (Sep 23 2026 at 12:59):

:memo: saulecabrera submitted PR review:

The fix looks good to me; it seems that we have a stale fuzzing config that we need to update here so that the fuzzers can actually exercise exceptions? https://github.com/bytecodealliance/wasmtime/blob/main/crates/fuzzing/src/generators/config.rs#L696

view this post on Zulip Wasmtime GitHub notifications bot (Sep 23 2026 at 14:37):

macovedj requested wasmtime-fuzz-reviewers for a review on PR #14379.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 23 2026 at 14:37):

macovedj updated PR #14379.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 23 2026 at 14:40):

macovedj commented on PR #14379:

The fix looks good to me; it seems that we have a stale fuzzing config that we need to update here so that the fuzzers can actually exercise exceptions? https://github.com/bytecodealliance/wasmtime/blob/main/crates/fuzzing/src/generators/config.rs#L696

Good catch! Updated. Also found another spot in oracles.rs where Cranelift was being forced over Winch for exceptions.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 23 2026 at 15:46):

github-actions[bot] added the label fuzzing on PR #14379.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 23 2026 at 15:47):

github-actions[bot] commented on PR #14379:

Subscribe to Label Action

cc @fitzgen

<details>
This issue or pull request has been labeled: "fuzzing"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (Sep 23 2026 at 16:49):

:thumbs_up: saulecabrera submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 23 2026 at 16:50):

saulecabrera added PR #14379 winch: handle unreachable try_table and fuel accounting to the merge queue.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 23 2026 at 17:15):

:check: saulecabrera merged PR #14379.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 23 2026 at 17:15):

saulecabrera removed PR #14379 winch: handle unreachable try_table and fuel accounting from the merge queue.


Last updated: Oct 11 2026 at 04:10 UTC