Stream: git-wasmtime

Topic: wasmtime / PR #14367 tweak CM async trap messages to matc...

Wasmtime GitHub notifications bot (Sep 21 2026 at 16:55):

dicej requested alexcrichton for a review on PR #14367.

Wasmtime GitHub notifications bot (Sep 21 2026 at 16:55):

dicej requested wasmtime-core-reviewers for a review on PR #14367.

Wasmtime GitHub notifications bot (Sep 21 2026 at 16:55):

dicej opened PR #14367 from dicej:fix-unreachable-traps to bytecodealliance:main:

PR #14342 included some unreachable code due partly to some code in wast.rs which only compared the first part of trap message strings which began with "cannot read" or "cannot write", leading me to think that certain code paths were being exercised when they really weren't. To avoid future confusion, I've removed those special cases in wast.rs and updated the code in futures_and_streams.rs to match the expected messages in the spec tests, as well as updating a couple of WAST tests we host locally in this repo.

Finally, this updates the tests/component-model submodule to include the new idle-drop.wast tests I mentioned in the earlier PR which have since been merged.

Fixes #14360

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please review the Bytecode Alliance's AI tool usage policy at
https://github.com/bytecodealliance/governance/blob/main/AI_TOOL_POLICY.md

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Sep 21 2026 at 17:07):

:thumbs_up: alexcrichton submitted PR review:

this updates the tests/component-model submodule

Was that forgotten to be committed? (I don't see it as part of this PR, but fine to include either here or in a follow-up of course)

Wasmtime GitHub notifications bot (Sep 21 2026 at 17:10):

dicej commented on PR #14367:

Was that forgotten to be committed? (I don't see it as part of this PR, but fine to include either here or in a follow-up of course)

Oops, nevermind. You did the update already in #14352. I got confused because I had to do the same update locally before I rebased onto main. I'll update my commit message.

Wasmtime GitHub notifications bot (Sep 21 2026 at 17:11):

dicej updated PR #14367.

Wasmtime GitHub notifications bot (Sep 21 2026 at 17:11):

dicej edited PR #14367:

PR #14342 included some unreachable code due partly to some code in wast.rs which only compared the first part of trap message strings which began with "cannot read" or "cannot write", leading me to think that certain code paths were being exercised when they really weren't. To avoid future confusion, I've removed those special cases in wast.rs and updated the code in futures_and_streams.rs to match the expected messages in the spec tests, as well as updating a couple of WAST tests we host locally in this repo.

Fixes #14360

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please review the Bytecode Alliance's AI tool usage policy at
https://github.com/bytecodealliance/governance/blob/main/AI_TOOL_POLICY.md

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Sep 21 2026 at 17:11):

dicej has enabled auto merge for PR #14367.

Wasmtime GitHub notifications bot (Sep 21 2026 at 17:20):

dicej added PR #14367 tweak CM async trap messages to match spec tests to the merge queue.

Wasmtime GitHub notifications bot (Sep 21 2026 at 17:46):

:check: dicej merged PR #14367.

Wasmtime GitHub notifications bot (Sep 21 2026 at 17:46):

dicej removed PR #14367 tweak CM async trap messages to match spec tests from the merge queue.

Last updated: Oct 11 2026 at 04:10 UTC