Stream: git-wasmtime

Topic: wasmtime / PR #14344 add canonical names flag to wasmtime...

view this post on Zulip Wasmtime GitHub notifications bot (Sep 15 2026 at 20:11):

chenyan2002 opened PR #14344 from chenyan2002:canon-ver to bytecodealliance:main:

Add -W component_model_canonical_names in wasmtime CLI.

When the flag is enabled, use canonicalized interface name in the Linker and ExportLookUp, so that interface name can be matched via string equality.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 15 2026 at 20:11):

chenyan2002 requested alexcrichton for a review on PR #14344.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 15 2026 at 20:11):

chenyan2002 requested wasmtime-fuzz-reviewers for a review on PR #14344.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 15 2026 at 20:11):

chenyan2002 requested wasmtime-core-reviewers for a review on PR #14344.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 15 2026 at 20:24):

:memo: alexcrichton submitted PR review:

Thanks! Plumbing looks fine but I'm less certain on one part below. I think we'll want to brainstorm a bit on how best to integrate into the API/etc.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 15 2026 at 20:24):

:speech_balloon: alexcrichton created PR review comment:

While I'm not entirely sure how we want to integrate cm-canon-names into the public API here I don't think that this is the way we'll want to do this. We've generally had bad experiences in the past if enabling a feature changes behavior, so I'd prefer to leave this as-is.

Would you be ok backing out the changes here and in linker.rs below and just landing the plumbing for now?

view this post on Zulip Wasmtime GitHub notifications bot (Sep 15 2026 at 20:52):

chenyan2002 updated PR #14344.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 15 2026 at 20:54):

chenyan2002 updated PR #14344.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 15 2026 at 20:56):

chenyan2002 updated PR #14344.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 15 2026 at 20:58):

chenyan2002 edited PR #14344:

Add -W component_model_canonical_names in wasmtime CLI.

For now, the host side binding is still using the full version, so Linker and ExportLookUp would fail with a canonicalized interface.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 15 2026 at 21:43):

:thumbs_up: alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 15 2026 at 21:43):

alexcrichton added PR #14344 add canonical names flag to wasmtime CLI to the merge queue.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 15 2026 at 22:10):

:check: alexcrichton merged PR #14344.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 15 2026 at 22:10):

alexcrichton removed PR #14344 add canonical names flag to wasmtime CLI from the merge queue.

Last updated: Sep 20 2026 at 18:08 UTC