Wasmtime GitHub notifications bot (Sep 15 2026 at 18:17): Wasmtime GitHub notifications bot (Sep 15 2026 at 18:17):dicej requested alexcrichton for a review on PR #14342.
Wasmtime GitHub notifications bot (Sep 15 2026 at 18:17):dicej requested wasmtime-core-reviewers for a review on PR #14342.
Wasmtime GitHub notifications bot (Sep 15 2026 at 18:17):dicej opened PR #14342 from dicej:fix-use-after-other-end-dropped to bytecodealliance:main:
https://github.com/WebAssembly/component-model/pull/719 adds some new tests that assert certain behavior when the guest has been notified that the other end of a stream or future has been dropped (e.g. trapping if the guest tried to keep using the handle), and this commit updates Wasmtime to match.
As of this writing, that PR has not yet been merged, so I'm not updating the
tests/component-modelsubmodule yet, but I've verified that the tests on the PR branch pass locally.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease review the Bytecode Alliance's AI tool usage policy at
https://github.com/bytecodealliance/governance/blob/main/AI_TOOL_POLICY.mdPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Sep 15 2026 at 18:27)::thumbs_up: alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Sep 15 2026 at 18:27)::speech_balloon: alexcrichton created PR review comment:
Could this get folded into the below? For example the
donelocal variable I think is the equivalent of calculating whether this should happen?
Wasmtime GitHub notifications bot (Sep 15 2026 at 19:36)::memo: dicej submitted PR review.
Wasmtime GitHub notifications bot (Sep 15 2026 at 19:36)::speech_balloon: dicej created PR review comment:
Yeah, I tried that, but the
matchbelow is also looking forpending: Some(_)and doing an early return otherwise; combining them got very awkward.I do think future/stream state and event delivery could use a refactor, but I expect that would extend beyond just this function and the scope of this PR.
Wasmtime GitHub notifications bot (Sep 15 2026 at 19:43)::memo: alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Sep 15 2026 at 19:43)::speech_balloon: alexcrichton created PR review comment:
Ah ok, sounds reasonable
Wasmtime GitHub notifications bot (Sep 15 2026 at 19:44):alexcrichton added PR #14342 fix new idle-drop.wast tests to the merge queue.
Wasmtime GitHub notifications bot (Sep 15 2026 at 20:10)::check: alexcrichton merged PR #14342.
Wasmtime GitHub notifications bot (Sep 15 2026 at 20:10):alexcrichton removed PR #14342 fix new idle-drop.wast tests from the merge queue.
Last updated: Sep 20 2026 at 18:08 UTC