Stream: git-wasmtime

Topic: wasmtime / PR #1434 Move back to only one WASI submodule

view this post on Zulip Wasmtime GitHub notifications bot (Mar 30 2020 at 16:07):

alexcrichton opened PR #1434 from one-wasi to master:

This commit fixes the issue where we have two WASI submodules for build
reasons in this repository. The fix was to place the submodule in the
wasi-common crate, and then anyone using the wig crate has to be
sure to define a WASI_ROOT env var in a build script to be able to
parse witx files.

With all that in place wasi-common becomes the source of truth for the
witx files we're parsing, and crates like wasmtime-wasi use
build-scripts shenanigans to read the same witx files. This should
hopefully get us so we're compatible with publishing and still only have
one submodule!

Closes https://github.com/bytecodealliance/wasmtime/issues/1427

view this post on Zulip Wasmtime GitHub notifications bot (Mar 30 2020 at 17:06):

alexcrichton updated PR #1434 from one-wasi to master:

This commit fixes the issue where we have two WASI submodules for build
reasons in this repository. The fix was to place the submodule in the
wasi-common crate, and then anyone using the wig crate has to be
sure to define a WASI_ROOT env var in a build script to be able to
parse witx files.

With all that in place wasi-common becomes the source of truth for the
witx files we're parsing, and crates like wasmtime-wasi use
build-scripts shenanigans to read the same witx files. This should
hopefully get us so we're compatible with publishing and still only have
one submodule!

Closes https://github.com/bytecodealliance/wasmtime/issues/1427

view this post on Zulip Wasmtime GitHub notifications bot (Mar 30 2020 at 18:32):

pchickey submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 30 2020 at 18:32):

pchickey created PR Review Comment:

This is really useful, I had no idea it existed.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 30 2020 at 18:32):

pchickey submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 30 2020 at 19:45):

alexcrichton merged PR #1434.

Last updated: Dec 23 2024 at 12:05 UTC