chacailline opened PR #14335 from chacailline:compact-imports to bytecodealliance:main:
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease review the Bytecode Alliance's AI tool usage policy at
https://github.com/bytecodealliance/governance/blob/main/AI_TOOL_POLICY.mdPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Adds support for the compact imports proposal, part of #14108.Adds:
Config::wasm_compact_importsoption, defaultfalse- CLI, TOML, and C/C++ API configuration options
- WAST test covering both types of compact imports
- Documentation updates
Waiting on 1 week of fuzzer runs to move the proposal to tier 1 and enable the proposal by default.
Please let me know if anything else needs to be added.
chacailline requested fitzgen for a review on PR #14335.
chacailline requested wasmtime-fuzz-reviewers for a review on PR #14335.
chacailline requested wasmtime-core-reviewers for a review on PR #14335.
chacailline requested wasmtime-default-reviewers for a review on PR #14335.
github-actions[bot] added the label fuzzing on PR #14335.
github-actions[bot] added the label wasmtime:api on PR #14335.
github-actions[bot] added the label wasmtime:c-api on PR #14335.
github-actions[bot] added the label wasmtime:docs on PR #14335.
github-actions[bot] added the label wasmtime:config on PR #14335.
github-actions[bot] commented on PR #14335:
Subscribe to Label Action
cc @fitzgen
<details>
This issue or pull request has been labeled: "fuzzing", "wasmtime:api", "wasmtime:c-api", "wasmtime:config", "wasmtime:docs"Thus the following users have been cc'd because of the following labels:
- fitzgen: fuzzing
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
github-actions[bot] commented on PR #14335:
Label Messager: wasmtime:config
It looks like you are changing Wasmtime's configuration options. Make sure to
complete this check list:
[ ] If you added a new
Configmethod, you wrote extensive documentation for
it.<details>
Our documentation should be of the following form:
```text
Short, simple summary sentence.More details. These details can be multiple paragraphs. There should be
information about not just the method, but its parameters and results as
well.Is this method fallible? If so, when can it return an error?
Can this method panic? If so, when does it panic?
Example
Optional example here.
```</details>
[ ] If you added a new
Configmethod, or modified an existing one, you
ensured that this configuration is exercised by the fuzz targets.<details>
For example, if you expose a new strategy for allocating the next instance
slot inside the pooling allocator, you should ensure that at least one of our
fuzz targets exercises that new strategy.Often, all that is required of you is to ensure that there is a knob for this
configuration option in [wasmtime_fuzzing::Config][fuzzing-config] (or one
of its nestedstructs).Rarely, this may require authoring a new fuzz target to specifically test this
configuration. See [our docs on fuzzing][fuzzing-docs] for more details.</details>
[ ] If you are enabling a configuration option by default, make sure that it
has been fuzzed for at least two weeks before turning it on by default.[fuzzing-config]: https://github.com/bytecodealliance/wasmtime/blob/ca0e8d0a1d8cefc0496dba2f77a670571d8fdcab/crates/fuzzing/src/generators.rs#L182-L194
[fuzzing-docs]: https://docs.wasmtime.dev/contributing-fuzzing.html
<details>
To modify this label's message, edit the <code>.github/label-messager/wasmtime-config.md</code> file.
To add new label messages or remove existing label messages, edit the
<code>.github/label-messager.json</code> configuration file.</details>
chacailline commented on PR #14335:
New config method has documentation in line with other feature config functions.
In local fuzzing runs,
instantiategenerated compact import statements. I think other ones that usewasm-smithshould as well.Config is off by default pending fuzzing. Btw docs Wasm Proposals says 1 week of fuzzing, but reminder bot says 2 weeks.
:memo: fitzgen submitted PR review:
LGTM, modulo two minor things below. Thanks!
:speech_balloon: fitzgen created PR review comment:
Does the spec testsuite not cover compact imports? I would have expected that we also enable running the spec tests for compact imports somewhere in
crates/test-util/src/wast.rsor something.
:speech_balloon: fitzgen created PR review comment:
The
[proposal]link is not actually used in the docs above, but should be.We should a short paragraph summary of what the proposal actually is/enables here as well, similar to other Wasm proposal knobs.
Last updated: Sep 20 2026 at 18:08 UTC