alexcrichton opened PR #14328 from alexcrichton:disable-memset-on-tables to bytecodealliance:main:
While the preexisting predicate worked for
funcreftables it didn't work for tables of GC reference types which require barriers under some collectors. After trying a few different shapes of this I've opted to just disable the optimization entirely since I don't think we have much relying on it and it seems best to start correct and optimize from there.I've additionally opted for a unit test rather than the
*.wasttest from #14325 which, while it works, takes a moment to churn through so much memory locally. To keep the test suite running relatively fast a smallerDrop-based test was chosen.Closes #14325
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease review the Bytecode Alliance's AI tool usage policy at
https://github.com/bytecodealliance/governance/blob/main/AI_TOOL_POLICY.mdPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
alexcrichton requested cfallin for a review on PR #14328.
alexcrichton requested wasmtime-compiler-reviewers for a review on PR #14328.
alexcrichton requested wasmtime-core-reviewers for a review on PR #14328.
:thumbs_up: cfallin submitted PR review.
cfallin added PR #14328 Disable using memset on tables to the merge queue.
:check: cfallin merged PR #14328.
cfallin removed PR #14328 Disable using memset on tables from the merge queue.
Last updated: Sep 20 2026 at 18:08 UTC