Stream: git-wasmtime

Topic: wasmtime / PR #14305 Make `sha2` an optional dependency o...

Wasmtime GitHub notifications bot (Sep 09 2026 at 13:19):

CfirTsabari opened PR #14305 from CfirTsabari:fix-sha2-optional to bytecodealliance:main:

The only code referencing sha2 is the use sha2::{Digest, Sha256}
import and the WasmChecksum::from_binary call site in
module_artifacts.rs, both of which are already behind
#[cfg(feature = "rr")]. Despite that, sha2 was declared as a plain
dependency, so every consumer of wasmtime-environ compiled and linked
it even when rr was disabled and the code was dead.

Mark the dependency optional = true and add dep:sha2 to the rr
feature so it is only pulled in when it is actually used. No code
changes were needed; the existing cfg gates already cover every
reference.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please review the Bytecode Alliance's AI tool usage policy at
https://github.com/bytecodealliance/governance/blob/main/AI_TOOL_POLICY.md

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Sep 09 2026 at 13:19):

CfirTsabari requested pchickey for a review on PR #14305.

Wasmtime GitHub notifications bot (Sep 09 2026 at 13:19):

CfirTsabari requested wasmtime-core-reviewers for a review on PR #14305.

Wasmtime GitHub notifications bot (Sep 09 2026 at 20:54):

:thumbs_up: pchickey submitted PR review.

Wasmtime GitHub notifications bot (Sep 09 2026 at 20:54):

pchickey added PR #14305 Make sha2 an optional dependency of wasmtime-environ to the merge queue

Wasmtime GitHub notifications bot (Sep 09 2026 at 21:20):

:check: pchickey merged PR #14305.

Wasmtime GitHub notifications bot (Sep 09 2026 at 21:20):

pchickey removed PR #14305 Make sha2 an optional dependency of wasmtime-environ from the merge queue

Last updated: Sep 20 2026 at 18:08 UTC