macovedj opened PR #14209 from macovedj:winch-catch-ref to bytecodealliance:main:
Adds Winch support for
catch_refandcatch_all_ref, the remaining unsupported catch forms in the exception-handling proposal. Updates the stability documentation to reflect Winch’s support for exception handling.
macovedj requested cfallin for a review on PR #14209.
macovedj requested wasmtime-compiler-reviewers for a review on PR #14209.
macovedj requested wasmtime-core-reviewers for a review on PR #14209.
macovedj requested alexcrichton for a review on PR #14209.
macovedj requested wasmtime-default-reviewers for a review on PR #14209.
github-actions[bot] added the label wasmtime:docs on PR #14209.
github-actions[bot] added the label wasmtime:api on PR #14209.
github-actions[bot] added the label winch on PR #14209.
github-actions[bot] added the label wasmtime:config on PR #14209.
github-actions[bot] commented on PR #14209:
Subscribe to Label Action
cc @saulecabrera
<details>
This issue or pull request has been labeled: "wasmtime:api", "wasmtime:config", "wasmtime:docs", "winch"Thus the following users have been cc'd because of the following labels:
- saulecabrera: winch
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
github-actions[bot] commented on PR #14209:
Label Messager: wasmtime:config
It looks like you are changing Wasmtime's configuration options. Make sure to
complete this check list:
[ ] If you added a new
Configmethod, you wrote extensive documentation for
it.<details>
Our documentation should be of the following form:
```text
Short, simple summary sentence.More details. These details can be multiple paragraphs. There should be
information about not just the method, but its parameters and results as
well.Is this method fallible? If so, when can it return an error?
Can this method panic? If so, when does it panic?
Example
Optional example here.
```</details>
[ ] If you added a new
Configmethod, or modified an existing one, you
ensured that this configuration is exercised by the fuzz targets.<details>
For example, if you expose a new strategy for allocating the next instance
slot inside the pooling allocator, you should ensure that at least one of our
fuzz targets exercises that new strategy.Often, all that is required of you is to ensure that there is a knob for this
configuration option in [wasmtime_fuzzing::Config][fuzzing-config] (or one
of its nestedstructs).Rarely, this may require authoring a new fuzz target to specifically test this
configuration. See [our docs on fuzzing][fuzzing-docs] for more details.</details>
[ ] If you are enabling a configuration option by default, make sure that it
has been fuzzed for at least two weeks before turning it on by default.[fuzzing-config]: https://github.com/bytecodealliance/wasmtime/blob/ca0e8d0a1d8cefc0496dba2f77a670571d8fdcab/crates/fuzzing/src/generators.rs#L182-L194
[fuzzing-docs]: https://docs.wasmtime.dev/contributing-fuzzing.html
<details>
To modify this label's message, edit the <code>.github/label-messager/wasmtime-config.md</code> file.
To add new label messages or remove existing label messages, edit the
<code>.github/label-messager.json</code> configuration file.</details>
alexcrichton unassigned cfallin from PR #14209 winch: catch exception references.
alexcrichton unassigned alexcrichton from PR #14209 winch: catch exception references.
alexcrichton requested saulecabrera for a review on PR #14209.
:memo: saulecabrera submitted PR review.
:speech_balloon: saulecabrera created PR review comment:
We have a dependency here between
catch.is_refandself.emit_load_exception_payload_fieldsI wonder if we could unify this such that we get that dependency removed between the two mehotds removed (and more importantly theboolparameter).
:speech_balloon: saulecabrera created PR review comment:
I am not sure if I flagged this before, but would it make sense to make the collector configurable through
wasmtime_test? Similar to what we have forstrategy?
macovedj updated PR #14209.
:thumbs_up: saulecabrera submitted PR review:
LGTM, thanks!
saulecabrera added PR #14209 winch: catch exception references to the merge queue.
:check: saulecabrera merged PR #14209.
saulecabrera removed PR #14209 winch: catch exception references from the merge queue.
Last updated: Aug 30 2026 at 09:07 UTC