Stream: git-wasmtime

Topic: wasmtime / PR #14191 Fix missing Host header in outgoing ...


view this post on Zulip Wasmtime GitHub notifications bot (Aug 21 2026 at 20:02):

tomasol opened PR #14191 from tomasol:add-host-header-main to bytecodealliance:main:

Fixes #14190

view this post on Zulip Wasmtime GitHub notifications bot (Aug 21 2026 at 20:02):

tomasol requested rvolosatovs for a review on PR #14191.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 21 2026 at 20:02):

tomasol requested wasmtime-wasi-reviewers for a review on PR #14191.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 21 2026 at 20:02):

tomasol requested pchickey for a review on PR #14191.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 21 2026 at 20:02):

tomasol requested wasmtime-core-reviewers for a review on PR #14191.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 21 2026 at 20:03):

tomasol edited PR #14191.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 21 2026 at 20:31):

tomasol updated PR #14191.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 21 2026 at 20:55):

:memo: rvolosatovs submitted PR review:

Could you verify that the issue still occurs on latest main without this diff?

I would have expected this to be fixed by https://github.com/bytecodealliance/wasmtime/pull/14167, HOST header should be set unless it's explicitly disabled in the embedding https://github.com/bytecodealliance/wasmtime/blob/e6b33de5139d915a48127fc78b790e2d306cf896/crates/wasi-http/src/p2/http_impl.rs#L80-L82 (this is enabled by default: https://github.com/bytecodealliance/wasmtime/blob/e6b33de5139d915a48127fc78b790e2d306cf896/crates/wasi-http/src/ctx.rs#L218-L221)

view this post on Zulip Wasmtime GitHub notifications bot (Aug 21 2026 at 21:04):

rvolosatovs commented on PR #14191:

FWIW,

$ curl -sL https://github.com/bytecodealliance/wasmtime/pull/14191.patch | git am -3
$ git checkout e6b33de513 -- crates/wasi-http/src
$ cargo test -p wasmtime-wasi-http

passed for me, so it does not look like the test reproduces an issue currently present on main

view this post on Zulip Wasmtime GitHub notifications bot (Aug 21 2026 at 21:08):

tomasol commented on PR #14191:

Right, I wrote it on top of v48.0.0 , and then just rebased on latest main, sorry for the noise.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 21 2026 at 21:08):

:cross_mark: tomasol closed without merge PR #14191.


Last updated: Aug 30 2026 at 09:07 UTC