Wasmtime GitHub notifications bot (Aug 17 2026 at 18:21): Wasmtime GitHub notifications bot (Aug 17 2026 at 18:21):adamrk opened PR #14148 from adamrk:request-new-future-fail to bytecodealliance:main:
Addresses https://github.com/bytecodealliance/wasmtime/issues/14112.
Instead of adding a new test, we modify existing tests which were just checking the response error to now check the transmission error.
As a drive by change, this also removes
BodyWithStatewhich seems to be unused.
Wasmtime GitHub notifications bot (Aug 17 2026 at 18:21):adamrk requested wasmtime-wasi-reviewers for a review on PR #14148.
Wasmtime GitHub notifications bot (Aug 17 2026 at 18:21):adamrk requested pchickey for a review on PR #14148.
Wasmtime GitHub notifications bot (Aug 17 2026 at 18:21):adamrk requested wasmtime-core-reviewers for a review on PR #14148.
Wasmtime GitHub notifications bot (Aug 17 2026 at 18:37):adamrk updated PR #14148.
Wasmtime GitHub notifications bot (Aug 17 2026 at 18:48):adamrk commented on PR #14148:
Current CI error seems to be Github's fault, but I don't have permissions to retry it.
Wasmtime GitHub notifications bot (Aug 17 2026 at 23:44):pchickey commented on PR #14148:
I kicked it. LGTM but I'd like @dicej to take a look if he has a moment, he might spot subtle stuff related to these futures that aren't apparent to me.
Wasmtime GitHub notifications bot (Aug 17 2026 at 23:44):pchickey requested dicej for a review on PR #14148.
Wasmtime GitHub notifications bot (Aug 17 2026 at 23:44):pchickey unassigned pchickey from PR #14148 Pass transmission errors to the future from {request, response}.new.
Wasmtime GitHub notifications bot (Aug 18 2026 at 14:22)::thumbs_up: dicej submitted PR review:
Thanks, @adamrk!
Wasmtime GitHub notifications bot (Aug 18 2026 at 14:22)::speech_balloon: dicej created PR review comment:
Is this
mapcall still serving any purpose? Can we remove it?
Wasmtime GitHub notifications bot (Aug 18 2026 at 14:22)::speech_balloon: dicej created PR review comment:
Nit: consider moving the string literal into a named constant to avoid the duplication.
Wasmtime GitHub notifications bot (Aug 18 2026 at 14:22)::speech_balloon: dicej created PR review comment:
Is the
boxed_unsynccall still serving a purpose here?
Wasmtime GitHub notifications bot (Aug 18 2026 at 14:48):adamrk updated PR #14148.
Wasmtime GitHub notifications bot (Aug 18 2026 at 14:48)::memo: adamrk submitted PR review.
Wasmtime GitHub notifications bot (Aug 18 2026 at 14:48)::speech_balloon: adamrk created PR review comment:
Yep, it's not needed anymore.
Wasmtime GitHub notifications bot (Aug 18 2026 at 14:49)::memo: adamrk submitted PR review.
Wasmtime GitHub notifications bot (Aug 18 2026 at 14:49)::speech_balloon: adamrk created PR review comment:
Done
Wasmtime GitHub notifications bot (Aug 18 2026 at 14:49)::memo: adamrk submitted PR review.
Wasmtime GitHub notifications bot (Aug 18 2026 at 14:49)::speech_balloon: adamrk created PR review comment:
This one could also be removed.
Wasmtime GitHub notifications bot (Aug 18 2026 at 14:49):adamrk requested dicej for a review on PR #14148.
Wasmtime GitHub notifications bot (Aug 26 2026 at 14:42):dicej added PR #14148 Pass transmission errors to the future from {request, response}.new to the merge queue
Wasmtime GitHub notifications bot (Aug 26 2026 at 15:10)::check: dicej merged PR #14148.
Wasmtime GitHub notifications bot (Aug 26 2026 at 15:10):dicej removed PR #14148 Pass transmission errors to the future from {request, response}.new from the merge queue
Last updated: Aug 30 2026 at 09:07 UTC