RuchitRathi opened PR #14145 from RuchitRathi:cranelift-alias-analysis-invariant to bytecodealliance:main:
Fixes #14131
Summary
Fixes a debug-only assertion in Cranelift alias analysis that incorrectly assumed the
observed_storesset cannot grow during later instruction processing. Additional observations may be discovered after dead-store or idempotent-store rewrites, so the set should be monotonic rather than fixed-size.Changes Made
- Updated
debug_assert!incranelift/codegen/src/alias_analysis.rsto check thatobserved_stores.len()only grows or stays the same (>=).- Added a regression test in
cranelift/filetests/filetests/alias/issue-14131.clif.Verification
- Tested single reproducer:
cargo +1.95.0 run -p cranelift-tools -- test cranelift/filetests/filetests/alias/issue-14131.clif(Passed)- Tested full alias suite:
cargo +1.95.0 run -p cranelift-tools -- test cranelift/filetests/filetests/alias(40 tests passed)
RuchitRathi requested fitzgen for a review on PR #14145.
RuchitRathi requested wasmtime-compiler-reviewers for a review on PR #14145.
RuchitRathi requested wasmtime-default-reviewers for a review on PR #14145.
github-actions[bot] added the label wasmtime:docs on PR #14145.
github-actions[bot] added the label cranelift on PR #14145.
:cross_mark: fitzgen closed without merge PR #14145.
fitzgen commented on PR #14145:
That issue is already fixed.
Last updated: Aug 30 2026 at 09:07 UTC