Stream: git-wasmtime

Topic: wasmtime / PR #1414 Shuffle around the wiggle crates

Wasmtime GitHub notifications bot (Mar 26 2020 at 16:13):

alexcrichton opened PR #1414 from one-wiggle to master:

This commit reorganizes the wiggle crates slightly by performing the
following transforms:

• The crates/wiggle crate, previously named wiggle, was moved to
  crates/wiggle/crates/macro and is renamed to wiggle-macro.

• The crates/wiggle/crates/runtime crate, previously named
  wiggle-runtime, was moved to crates/wiggle and is renamed to
  wiggle.

• The new wiggle crate depends on wiggle-macro and reexports the macro.

The goal here is that consumers only deal with the wiggle crate
itself. No more crates depend on wiggle-runtime and all dependencies
are entirely on just the wiggle crate.

Wasmtime GitHub notifications bot (Mar 26 2020 at 16:13):

alexcrichton requested pchickey for a review on PR #1414.

Wasmtime GitHub notifications bot (Mar 26 2020 at 16:17):

pchickey submitted PR Review.

Wasmtime GitHub notifications bot (Mar 26 2020 at 16:17):

pchickey created PR Review Comment:

do you have to add wiggle-macro back here?

Wasmtime GitHub notifications bot (Mar 26 2020 at 16:18):

pchickey edited PR Review Comment.

Wasmtime GitHub notifications bot (Mar 26 2020 at 16:22):

alexcrichton submitted PR Review.

Wasmtime GitHub notifications bot (Mar 26 2020 at 16:22):

alexcrichton created PR Review Comment:

Sure yeah. TBH I don't know the fate of this script and it already tests very little compared to CI, but can't hurt to keep touching it.

Wasmtime GitHub notifications bot (Mar 26 2020 at 16:25):

alexcrichton updated PR #1414 from one-wiggle to master:

This commit reorganizes the wiggle crates slightly by performing the
following transforms:

• The crates/wiggle crate, previously named wiggle, was moved to
  crates/wiggle/crates/macro and is renamed to wiggle-macro.

• The crates/wiggle/crates/runtime crate, previously named
  wiggle-runtime, was moved to crates/wiggle and is renamed to
  wiggle.

• The new wiggle crate depends on wiggle-macro and reexports the macro.

The goal here is that consumers only deal with the wiggle crate
itself. No more crates depend on wiggle-runtime and all dependencies
are entirely on just the wiggle crate.

Wasmtime GitHub notifications bot (Mar 26 2020 at 16:27):

alexcrichton updated PR #1414 from one-wiggle to master:

This commit reorganizes the wiggle crates slightly by performing the
following transforms:

• The crates/wiggle crate, previously named wiggle, was moved to
  crates/wiggle/crates/macro and is renamed to wiggle-macro.

• The crates/wiggle/crates/runtime crate, previously named
  wiggle-runtime, was moved to crates/wiggle and is renamed to
  wiggle.

• The new wiggle crate depends on wiggle-macro and reexports the macro.

The goal here is that consumers only deal with the wiggle crate
itself. No more crates depend on wiggle-runtime and all dependencies
are entirely on just the wiggle crate.

Wasmtime GitHub notifications bot (Mar 26 2020 at 17:03):

pchickey submitted PR Review.

Wasmtime GitHub notifications bot (Mar 26 2020 at 17:03):

pchickey created PR Review Comment:

thanks, i hadn't paid attention to all of that discussion.

Wasmtime GitHub notifications bot (Mar 26 2020 at 23:02):

alexcrichton updated PR #1414 from one-wiggle to master:

This commit reorganizes the wiggle crates slightly by performing the
following transforms:

• The crates/wiggle crate, previously named wiggle, was moved to
  crates/wiggle/crates/macro and is renamed to wiggle-macro.

• The crates/wiggle/crates/runtime crate, previously named
  wiggle-runtime, was moved to crates/wiggle and is renamed to
  wiggle.

• The new wiggle crate depends on wiggle-macro and reexports the macro.

The goal here is that consumers only deal with the wiggle crate
itself. No more crates depend on wiggle-runtime and all dependencies
are entirely on just the wiggle crate.

Wasmtime GitHub notifications bot (Mar 26 2020 at 23:34):

alexcrichton merged PR #1414.

Last updated: Dec 23 2024 at 12:05 UTC