Wasmtime GitHub notifications bot (Aug 13 2026 at 09:51): Wasmtime GitHub notifications bot (Aug 13 2026 at 09:51):macovedj opened PR #14132 from macovedj:winch-trap-on-throw to bytecodealliance:main:
This PR begins the process of adding EH support for Winch. Following the approach outlined in the rfc, this first step compiles
try_tableas a plain block and compilesthrowandthrow_refas uncatchable traps. Follow on PRs will implement fullcatch/throwbehavior.
Wasmtime GitHub notifications bot (Aug 13 2026 at 09:51):macovedj requested fitzgen for a review on PR #14132.
Wasmtime GitHub notifications bot (Aug 13 2026 at 09:51):macovedj requested wasmtime-compiler-reviewers for a review on PR #14132.
Wasmtime GitHub notifications bot (Aug 13 2026 at 09:51):macovedj requested wasmtime-core-reviewers for a review on PR #14132.
Wasmtime GitHub notifications bot (Aug 13 2026 at 10:12):macovedj updated PR #14132.
Wasmtime GitHub notifications bot (Aug 13 2026 at 11:57):github-actions[bot] added the label wasmtime:api on PR #14132.
Wasmtime GitHub notifications bot (Aug 13 2026 at 11:57):github-actions[bot] added the label wasmtime:config on PR #14132.
Wasmtime GitHub notifications bot (Aug 13 2026 at 11:57):github-actions[bot] added the label winch on PR #14132.
Wasmtime GitHub notifications bot (Aug 13 2026 at 11:57):github-actions[bot] commented on PR #14132:
Subscribe to Label Action
cc @saulecabrera
<details>
This issue or pull request has been labeled: "wasmtime:api", "wasmtime:config", "winch"Thus the following users have been cc'd because of the following labels:
- saulecabrera: winch
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Aug 13 2026 at 13:05):github-actions[bot] commented on PR #14132:
Label Messager: wasmtime:config
It looks like you are changing Wasmtime's configuration options. Make sure to
complete this check list:
[ ] If you added a new
Configmethod, you wrote extensive documentation for
it.<details>
Our documentation should be of the following form:
```text
Short, simple summary sentence.More details. These details can be multiple paragraphs. There should be
information about not just the method, but its parameters and results as
well.Is this method fallible? If so, when can it return an error?
Can this method panic? If so, when does it panic?
Example
Optional example here.
```</details>
[ ] If you added a new
Configmethod, or modified an existing one, you
ensured that this configuration is exercised by the fuzz targets.<details>
For example, if you expose a new strategy for allocating the next instance
slot inside the pooling allocator, you should ensure that at least one of our
fuzz targets exercises that new strategy.Often, all that is required of you is to ensure that there is a knob for this
configuration option in [wasmtime_fuzzing::Config][fuzzing-config] (or one
of its nestedstructs).Rarely, this may require authoring a new fuzz target to specifically test this
configuration. See [our docs on fuzzing][fuzzing-docs] for more details.</details>
[ ] If you are enabling a configuration option by default, make sure that it
has been fuzzed for at least two weeks before turning it on by default.[fuzzing-config]: https://github.com/bytecodealliance/wasmtime/blob/ca0e8d0a1d8cefc0496dba2f77a670571d8fdcab/crates/fuzzing/src/generators.rs#L182-L194
[fuzzing-docs]: https://docs.wasmtime.dev/contributing-fuzzing.html
<details>
To modify this label's message, edit the <code>.github/label-messager/wasmtime-config.md</code> file.
To add new label messages or remove existing label messages, edit the
<code>.github/label-messager.json</code> configuration file.</details>
Wasmtime GitHub notifications bot (Aug 13 2026 at 16:14)::memo: saulecabrera submitted PR review.
Wasmtime GitHub notifications bot (Aug 13 2026 at 16:14)::speech_balloon: saulecabrera created PR review comment:
<A as ABI>::sizeof(&ty)below has this exact same validation. Instead of panicking, perhaps we could make this method returnResult<u8>. This is a larger refactoring than adding this validation here, but consolidates the type validations to a centralized place.
Wasmtime GitHub notifications bot (Aug 13 2026 at 16:14)::speech_balloon: saulecabrera created PR review comment:
I think this change is completely orthogonal to this PR? I removed it and nothing seems to break. Maybe we should add it in a different PR?
It seems that without this, compiling an exceptions module, results in a when resolving the
gc_compiler?
Wasmtime GitHub notifications bot (Aug 13 2026 at 16:14)::speech_balloon: saulecabrera created PR review comment:
Could we encode this rule in the
wasmtime_testmacro instead of duplicating it?
Wasmtime GitHub notifications bot (Aug 13 2026 at 19:03):macovedj updated PR #14132.
Wasmtime GitHub notifications bot (Aug 13 2026 at 19:05)::memo: macovedj submitted PR review.
Wasmtime GitHub notifications bot (Aug 13 2026 at 19:05)::speech_balloon: macovedj created PR review comment:
Makes sense! I actually also caught another redundant check while propagating the error that I was able to get rid of too.
Wasmtime GitHub notifications bot (Aug 13 2026 at 19:07)::memo: macovedj submitted PR review.
Wasmtime GitHub notifications bot (Aug 13 2026 at 19:07)::speech_balloon: macovedj created PR review comment:
Before I do, I didn't actually have to add the rule to every test. I'm not sure there's a clean way to leave the tests that don't need it. But also ideally this change shouldn't be here very long since I intend to follow up with the rest of the EH implementation soon. If you're comfortable with it, I can go ahead add some logic to just disable all of these tests for the time being.
Wasmtime GitHub notifications bot (Aug 13 2026 at 19:09)::memo: macovedj submitted PR review.
Wasmtime GitHub notifications bot (Aug 13 2026 at 19:09)::speech_balloon: macovedj created PR review comment:
Ah yeah I see what you mean. I will point out that I actually encountered the error when fiddling with the config to see the relationship between the various proposals. Not sure it will be clear which PR it actually belongs with, but I'm happy to leave this out for now and went ahead and got rid of the check.
Wasmtime GitHub notifications bot (Aug 14 2026 at 13:48)::thumbs_up: saulecabrera submitted PR review:
LGTM, thanks!
Wasmtime GitHub notifications bot (Aug 14 2026 at 13:48):saulecabrera added PR #14132 winch: compile exceptions as uncatchable traps to the merge queue.
Wasmtime GitHub notifications bot (Aug 14 2026 at 14:15)::check: saulecabrera merged PR #14132.
Wasmtime GitHub notifications bot (Aug 14 2026 at 14:15):saulecabrera removed PR #14132 winch: compile exceptions as uncatchable traps from the merge queue.
Last updated: Aug 30 2026 at 09:07 UTC