Stream: git-wasmtime

Topic: wasmtime / PR #1413 Fix debug asserts for dwarf transform

view this post on Zulip Wasmtime GitHub notifications bot (Mar 26 2020 at 15:36):

yurydelendik opened PR #1413 from issue1408 to master:

Fixes #1408

The refactored debug_assert! was poorly designed / afterthought. The PR fixes that by properly checking the iterator item order invariant. Not sure if it requires a test.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 26 2020 at 15:36):

yurydelendik requested alexcrichton for a review on PR #1413.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 26 2020 at 15:58):

yurydelendik updated PR #1413 from issue1408 to master:

Fixes #1408

The refactored debug_assert! was poorly designed / afterthought. The PR fixes that by properly checking the iterator item order invariant. Not sure if it requires a test.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 26 2020 at 17:25):

alexcrichton merged PR #1413.

Last updated: Dec 23 2024 at 12:05 UTC