alexcrichton opened PR #14121 from alexcrichton:require-reference-types to bytecodealliance:main:
Adapters between components internally use the
ref.funcinstruction which requires the reference-types proposal. Without this compilation may panic due to the adapter module not validating correctly. To handle this a new validation predicate is added toConfigto double-check that if component-model-async is enabled that reference-types is also enabled. To avoid updating dozens of tests this updates logic to enable the reference-types proposal to implicitly do that when the component-model-async proposal is enabled for a test.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
alexcrichton requested wasmtime-fuzz-reviewers for a review on PR #14121.
alexcrichton requested wasmtime-core-reviewers for a review on PR #14121.
alexcrichton updated PR #14121.
github-actions[bot] added the label fuzzing on PR #14121.
github-actions[bot] added the label wasmtime:api on PR #14121.
github-actions[bot] added the label wasmtime:config on PR #14121.
github-actions[bot] commented on PR #14121:
Subscribe to Label Action
cc @fitzgen
<details>
This issue or pull request has been labeled: "fuzzing", "wasmtime:api", "wasmtime:config"Thus the following users have been cc'd because of the following labels:
- fitzgen: fuzzing
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
github-actions[bot] commented on PR #14121:
Label Messager: wasmtime:config
It looks like you are changing Wasmtime's configuration options. Make sure to
complete this check list:
[ ] If you added a new
Configmethod, you wrote extensive documentation for
it.<details>
Our documentation should be of the following form:
```text
Short, simple summary sentence.More details. These details can be multiple paragraphs. There should be
information about not just the method, but its parameters and results as
well.Is this method fallible? If so, when can it return an error?
Can this method panic? If so, when does it panic?
Example
Optional example here.
```</details>
[ ] If you added a new
Configmethod, or modified an existing one, you
ensured that this configuration is exercised by the fuzz targets.<details>
For example, if you expose a new strategy for allocating the next instance
slot inside the pooling allocator, you should ensure that at least one of our
fuzz targets exercises that new strategy.Often, all that is required of you is to ensure that there is a knob for this
configuration option in [wasmtime_fuzzing::Config][fuzzing-config] (or one
of its nestedstructs).Rarely, this may require authoring a new fuzz target to specifically test this
configuration. See [our docs on fuzzing][fuzzing-docs] for more details.</details>
[ ] If you are enabling a configuration option by default, make sure that it
has been fuzzed for at least two weeks before turning it on by default.[fuzzing-config]: https://github.com/bytecodealliance/wasmtime/blob/ca0e8d0a1d8cefc0496dba2f77a670571d8fdcab/crates/fuzzing/src/generators.rs#L182-L194
[fuzzing-docs]: https://docs.wasmtime.dev/contributing-fuzzing.html
<details>
To modify this label's message, edit the <code>.github/label-messager/wasmtime-config.md</code> file.
To add new label messages or remove existing label messages, edit the
<code>.github/label-messager.json</code> configuration file.</details>
:thumbs_up: pchickey submitted PR review.
alexcrichton added PR #14121 Require the reference-types feature for component-model-async to the merge queue.
github-merge-queue[bot] removed PR #14121 Require the reference-types feature for component-model-async from the merge queue.
alexcrichton added PR #14121 Require the reference-types feature for component-model-async to the merge queue.
github-merge-queue[bot] removed PR #14121 Require the reference-types feature for component-model-async from the merge queue.
alexcrichton added PR #14121 Require the reference-types feature for component-model-async to the merge queue.
github-merge-queue[bot] removed PR #14121 Require the reference-types feature for component-model-async from the merge queue.
alexcrichton added PR #14121 Require the reference-types feature for component-model-async to the merge queue.
github-merge-queue[bot] removed PR #14121 Require the reference-types feature for component-model-async from the merge queue.
alexcrichton added PR #14121 Require the reference-types feature for component-model-async to the merge queue.
github-merge-queue[bot] removed PR #14121 Require the reference-types feature for component-model-async from the merge queue.
alexcrichton added PR #14121 Require the reference-types feature for component-model-async to the merge queue.
github-merge-queue[bot] removed PR #14121 Require the reference-types feature for component-model-async from the merge queue.
alexcrichton added PR #14121 Require the reference-types feature for component-model-async to the merge queue.
:check: alexcrichton merged PR #14121.
alexcrichton removed PR #14121 Require the reference-types feature for component-model-async from the merge queue.
Last updated: Aug 30 2026 at 09:07 UTC