Stream: git-wasmtime

Topic: wasmtime / PR #14113 Lower fused adapter `trap` intrinsic...

view this post on Zulip Wasmtime GitHub notifications bot (Aug 10 2026 at 20:32):

fitzgen opened PR #14113 from fitzgen:use-clif-trap-inst-in-fused-adapters to bytecodealliance:main:

Before, we would emit a call to a host function, passing the trap code as a
constant argument. Now we emit a trap <code> instruction directly.

This is a large improvement for our sync adapter disas tests.

Depends on https://github.com/bytecodealliance/wasmtime/pull/14111

view this post on Zulip Wasmtime GitHub notifications bot (Aug 10 2026 at 20:32):

fitzgen requested alexcrichton for a review on PR #14113.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 10 2026 at 20:32):

fitzgen requested wasmtime-compiler-reviewers for a review on PR #14113.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 10 2026 at 20:32):

fitzgen requested wasmtime-core-reviewers for a review on PR #14113.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 10 2026 at 21:04):

:memo: alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 10 2026 at 21:04):

:speech_balloon: alexcrichton created PR review comment:

I'm a bit wary of doing this even though it probably works out generally fine, but for example with guest-debug enabled I'd be worried that we'd spill/reload something or something like that. Could the payload here be directly on FactInlineIntrinsic::Trap? That'd require adding it to Trampoline::Trap too which I suspect wouldn't have much impact.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 10 2026 at 22:56):

github-actions[bot] added the label cranelift on PR #14113.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 12 2026 at 21:47):

fitzgen updated PR #14113.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 12 2026 at 21:48):

:memo: fitzgen submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 12 2026 at 21:48):

:speech_balloon: fitzgen created PR review comment:

Just pushed a commit implementing this. A bit of shepherding and such, but ultimately nicer yeah.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 12 2026 at 21:56):

:thumbs_up: alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 12 2026 at 22:57):

github-actions[bot] added the label wasmtime:api on PR #14113.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 13 2026 at 13:44):

fitzgen has enabled auto merge for PR #14113.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 13 2026 at 13:52):

fitzgen added PR #14113 Lower fused adapter trap intrinsics to CLIF trap instructions to the merge queue.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 13 2026 at 14:17):

fitzgen removed PR #14113 Lower fused adapter trap intrinsics to CLIF trap instructions from the merge queue.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 13 2026 at 14:17):

:check: fitzgen merged PR #14113.

Last updated: Aug 30 2026 at 10:08 UTC