cfallin opened PR #14095 from cfallin:fix-comment to bytecodealliance:main:
We previously noted that instrumentation slots were not seen by a GC, and only implicitly rooted (by live program values) for a non-moving GC. However as part of landing debug support, we eventually had to add proper rooting; the GC now explicitly scans instrumentation slots on the stack as well as the user stackslots. So this comment is out-of-date, and moving GCs work fine with debug (which is great, because we have one now!).
Fixes #13798.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
cfallin requested alexcrichton for a review on PR #14095.
cfallin requested wasmtime-compiler-reviewers for a review on PR #14095.
:thumbs_up: alexcrichton submitted PR review.
alexcrichton added PR #14095 Wasmtime debug instrumentation: remove stale comment about moving GCs. to the merge queue
:check: alexcrichton merged PR #14095.
alexcrichton removed PR #14095 Wasmtime debug instrumentation: remove stale comment about moving GCs. from the merge queue
Last updated: Aug 30 2026 at 09:07 UTC