Wasmtime GitHub notifications bot (Aug 05 2026 at 20:28): Wasmtime GitHub notifications bot (Aug 05 2026 at 20:28):fitzgen opened PR #14083 from fitzgen:vmctx-types-into-macro to bytecodealliance:main:
And automatically generate their offsets, alias region load/store helpers, etc... from the single macro definition. Similar to the existing macro for other
VM*types, but these definitions are parameterized over a specific Wasm module or component and the entities defined therein.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Aug 05 2026 at 20:28):fitzgen requested alexcrichton for a review on PR #14083.
Wasmtime GitHub notifications bot (Aug 05 2026 at 20:28):fitzgen requested wasmtime-compiler-reviewers for a review on PR #14083.
Wasmtime GitHub notifications bot (Aug 05 2026 at 20:28):fitzgen requested wasmtime-core-reviewers for a review on PR #14083.
Wasmtime GitHub notifications bot (Aug 05 2026 at 22:05):github-actions[bot] added the label wasmtime:api on PR #14083.
Wasmtime GitHub notifications bot (Aug 05 2026 at 22:05):github-actions[bot] added the label winch on PR #14083.
Wasmtime GitHub notifications bot (Aug 05 2026 at 22:06):github-actions[bot] commented on PR #14083:
Subscribe to Label Action
cc @saulecabrera
<details>
This issue or pull request has been labeled: "wasmtime:api", "winch"Thus the following users have been cc'd because of the following labels:
- saulecabrera: winch
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Aug 07 2026 at 17:03)::thumbs_up: alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Aug 07 2026 at 17:03)::speech_balloon: alexcrichton created PR review comment:
Since accesses like this (throughout the runtime) can be perf-sensitive, have you double-checked that methods are inlined and/or
#[inline]'d as needed?
Wasmtime GitHub notifications bot (Aug 10 2026 at 23:15)::memo: fitzgen submitted PR review.
Wasmtime GitHub notifications bot (Aug 10 2026 at 23:15)::speech_balloon: fitzgen created PR review comment:
I marked everything
#[inline]but I haven't actually dug through disassemblies -- do you think that is necessary?
Wasmtime GitHub notifications bot (Aug 11 2026 at 14:23)::memo: alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Aug 11 2026 at 14:23)::speech_balloon: alexcrichton created PR review comment:
No mostly just want to double-check you were considering this in the implementation. We can always slap
#[inline]on things retroactively and we don't have the infrastructure right now to say we should proactively be using#[inline], so "mostly considered during writing" I think is about the best we can do
Wasmtime GitHub notifications bot (Aug 13 2026 at 13:39)::memo: fitzgen submitted PR review.
Wasmtime GitHub notifications bot (Aug 13 2026 at 13:39)::speech_balloon: fitzgen created PR review comment:
FWIW, I'd expect everything here to be just as, if not more, amenable to to LLVM's optimizer.
Wasmtime GitHub notifications bot (Aug 13 2026 at 13:39):fitzgen added PR #14083 Define VMContext and VMComponentContext in a macro to the merge queue.
Wasmtime GitHub notifications bot (Aug 13 2026 at 13:47):github-merge-queue[bot] removed PR #14083 Define VMContext and VMComponentContext in a macro from the merge queue.
Wasmtime GitHub notifications bot (Aug 13 2026 at 20:38):fitzgen updated PR #14083.
Wasmtime GitHub notifications bot (Aug 13 2026 at 20:38):fitzgen has enabled auto merge for PR #14083.
Wasmtime GitHub notifications bot (Aug 13 2026 at 20:50):fitzgen added PR #14083 Define VMContext and VMComponentContext in a macro to the merge queue.
Wasmtime GitHub notifications bot (Aug 13 2026 at 21:16)::check: fitzgen merged PR #14083.
Wasmtime GitHub notifications bot (Aug 13 2026 at 21:16):fitzgen removed PR #14083 Define VMContext and VMComponentContext in a macro from the merge queue.
Last updated: Aug 30 2026 at 09:07 UTC