dishmaker opened PR #14078 from dishmaker:dishmaker/perf_opt_print_rawinst_display to bytecodealliance:main:
This decreases
cargo llvm-linesfrom1698144to1687711.Change:
-0.61%Should decrease compile times too.
cargo llvm-lines -p cranelift-codegen -F anyhow,capstone,disas,enable-serde,gimli,host-arch,incremental-cache,postcard,pulley,serde,serde_derive,sha2,std,timing,unwindBefore: Lines Copies Function name ----- ------ ------------- 1698144 46552 (TOTAL) 31987 (1.9%, 1.9%) 1 (0.0%, 0.0%) cranelift_codegen[8ba54695291ce448]::isa::pulley_shared::inst::generated::print 27885 (1.6%, 3.5%) 1 (0.0%, 0.0%) cranelift_codegen[8ba54695291ce448]::isa::x64::lower::isle::generated_code::constructor_lower::<cranelift_codegen[8ba54695291ce448]::machinst::isle::IsleContext<cranelift_codegen[8ba54695291ce448]::isa::x64::lower::isle::generated_code::MInst, cranelift_codegen[8ba54695291ce448]::isa::x64::X64Backend>> After: Lines Copies Function name ----- ------ ------------- 1687711 46552 (TOTAL) 27885 (1.7%, 1.7%) 1 (0.0%, 0.0%) cranelift_codegen[8ba54695291ce448]::isa::x64::lower::isle::generated_code::constructor_lower::<cranelift_codegen[8ba54695291ce448]::machinst::isle::IsleContext<cranelift_codegen[8ba54695291ce448]::isa::x64::lower::isle::generated_code::MInst, cranelift_codegen[8ba54695291ce448]::isa::x64::X64Backend>> 22445 (1.3%, 3.0%) 1 (0.0%, 0.0%) <cranelift_codegen[8ba54695291ce448]::isa::pulley_shared::inst::generated::RawInstDisplay as core[9cde01f631c9b89d]::fmt::Display>::fmtrustc -V rustc 1.99.0-nightly (da86f4d07 2026-07-24)
dishmaker requested alexcrichton for a review on PR #14078.
dishmaker requested wasmtime-compiler-reviewers for a review on PR #14078.
dishmaker commented on PR #14078:
Oh. This actually increases
llvm-lineson--release
dishmaker converted PR #14078 perf: cranelift: codegen: optimize RawInst print using fmt::Display to a draft
dishmaker edited a comment on PR #14078:
Oh. This actually increases
llvm-lineson--releaseby+1.13%
dishmaker commented on PR #14078:
Looks ok for
--releasetoo.
It reduces releasewasmtimebinary.textsection by-0.057 %
cargo bloat: from33.26 MiBto33.24 MiB
dishmaker has marked PR #14078 as ready for review.
github-actions[bot] added the label cranelift:meta on PR #14078.
github-actions[bot] added the label cranelift on PR #14078.
:thumbs_up: alexcrichton submitted PR review.
alexcrichton added PR #14078 perf: cranelift: codegen: optimize RawInst print using fmt::Display to the merge queue
:check: alexcrichton merged PR #14078.
alexcrichton removed PR #14078 perf: cranelift: codegen: optimize RawInst print using fmt::Display from the merge queue
Last updated: Aug 30 2026 at 09:07 UTC