Stream: git-wasmtime

Topic: wasmtime / PR #14017 Don't use `std::env::vars` for inher...

Wasmtime GitHub notifications bot (Jul 29 2026 at 14:45):

alexcrichton opened PR #14017 from alexcrichton:no-panic-env-var to bytecodealliance:main:

This internally panics on environment variables with invalid utf-8, but that's something we want to catch gracefully on the CLI.

Closes #14014

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Jul 29 2026 at 14:45):

alexcrichton requested pchickey for a review on PR #14017.

Wasmtime GitHub notifications bot (Jul 29 2026 at 14:45):

alexcrichton requested wasmtime-core-reviewers for a review on PR #14017.

Wasmtime GitHub notifications bot (Jul 29 2026 at 14:52):

:memo: bjorn3 submitted PR review.

Wasmtime GitHub notifications bot (Jul 29 2026 at 14:52):

:speech_balloon: bjorn3 created PR review comment:

                let k = k
                    .to_str()
                    .ok_or_else(|| format_err!("environment variable name {k:?} not valid utf-8"))?;
                let v = v
                    .to_str()
                    .ok_or_else(|| format_err!("environment variable {k:?} value {v:?} not valid utf-8"))?;

Wasmtime GitHub notifications bot (Jul 29 2026 at 15:10):

alexcrichton updated PR #14017.

Wasmtime GitHub notifications bot (Jul 29 2026 at 15:28):

alexcrichton updated PR #14017.

Wasmtime GitHub notifications bot (Jul 29 2026 at 16:39):

:thumbs_up: pchickey submitted PR review.

Wasmtime GitHub notifications bot (Jul 29 2026 at 16:42):

alexcrichton added PR #14017 Don't use std::env::vars for inheriting env vars to the merge queue.

Wasmtime GitHub notifications bot (Jul 29 2026 at 17:07):

:check: alexcrichton merged PR #14017.

Wasmtime GitHub notifications bot (Jul 29 2026 at 17:07):

alexcrichton removed PR #14017 Don't use std::env::vars for inheriting env vars from the merge queue.

Last updated: Aug 30 2026 at 10:08 UTC