fitzgen opened PR #14004 from fitzgen:issue-13961-alias-analysis-panic to bytecodealliance:main:
Fixes #13961
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
fitzgen requested cfallin for a review on PR #14004.
fitzgen requested wasmtime-compiler-reviewers for a review on PR #14004.
github-actions[bot] added the label cranelift on PR #14004.
:memo: cfallin submitted PR review.
:speech_balloon: cfallin created PR review comment:
This seems like a bandaid to me: it papers over the fact that the defining inst in the
mem_valuesmay be a removed instruction by just skipping the processing. Could we instead avoid inserting intomem_valuesif we determine the store is dead?
fitzgen updated PR #14004.
:memo: fitzgen submitted PR review.
:speech_balloon: fitzgen created PR review comment:
Made it so that
mem_valuesnever holds an instruction not in the layout (doing the same forLastStoreswas not practical, see the comment in the new code)
fitzgen requested cfallin for a review on PR #14004.
:thumbs_up: cfallin submitted PR review.
cfallin added PR #14004 Fix panic in alias analysis when a load follows an eliminated store to the merge queue.
github-merge-queue[bot] removed PR #14004 Fix panic in alias analysis when a load follows an eliminated store from the merge queue.
alexcrichton added PR #14004 Fix panic in alias analysis when a load follows an eliminated store to the merge queue.
:check: alexcrichton merged PR #14004.
alexcrichton removed PR #14004 Fix panic in alias analysis when a load follows an eliminated store from the merge queue.
Last updated: Aug 30 2026 at 10:08 UTC