avanhatt requested wasmtime-compiler-reviewers for a review on PR #13998.
avanhatt requested cfallin for a review on PR #13998.
avanhatt opened PR #13998 from avanhatt:veri-spec-type-check to bytecodealliance:main:
Type check term specs in isolation, and fix the over-constrained specs it finds.
Adds a check that type-checks verification conditions for each term used in an ISLE compilation one at a time, against nothing but its own declared types, so that a genuine type conflict is distinct from an expansion that shouldn't be reached for a specific type.
The one gnarly case is the spec for
aarch64MInst.MovFromVec: becauseaarch64does not have separateRegtypes for distinct sizes, it's difficult to faithfully model 128-bit-registers via ouraslpautomatically generated specs. Adds a special case to onlyspecthe low 64-bits of the register and leave the top unconstrained (sound, but incomplete).
github-actions[bot] added the label cranelift on PR #13998.
github-actions[bot] added the label cranelift:area:aarch64 on PR #13998.
github-actions[bot] added the label isle on PR #13998.
github-actions[bot] added the label cranelift:area:x64 on PR #13998.
github-actions[bot] commented on PR #13998:
Subscribe to Label Action
cc @cfallin, @fitzgen
<details>
This issue or pull request has been labeled: "cranelift", "cranelift:area:aarch64", "cranelift:area:x64", "isle"Thus the following users have been cc'd because of the following labels:
- cfallin: isle
- fitzgen: isle
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Last updated: Jul 29 2026 at 05:03 UTC