Stream: git-wasmtime

Topic: wasmtime / PR #13977 fix(gc): restore trace_infos if work...

Wasmtime GitHub notifications bot (Jul 25 2026 at 10:56):

SebTardif opened PR #13977 from SebTardif:fix/gc-restore-trace-infos-on-error to bytecodealliance:main:

Summary

process_worklist_increment took ownership of heap.trace_infos with mem::take and only restored it on the success path. If worklist_pop() or scan() returned an error, the temporary Vec was dropped and the heap permanently lost its trace table for the rest of the collection.

Fix

Run the increment body in a closure and always assign self.heap.trace_infos = trace_infos afterward, whether the result is Ok or Err.

Testing

• Logic review of all ? exits inside the increment body (worklist_pop, heap_index, scan)
• No public-API host test exercises a forced mid-increment GC error without a custom trap; the restoration is local and mechanical

Notes

Matches the Bytecode Alliance preference for small, fully understood correctness patches.

Wasmtime GitHub notifications bot (Jul 25 2026 at 10:56):

SebTardif requested pchickey for a review on PR #13977.

Wasmtime GitHub notifications bot (Jul 25 2026 at 10:56):

SebTardif requested wasmtime-core-reviewers for a review on PR #13977.

Wasmtime GitHub notifications bot (Jul 25 2026 at 12:03):

github-actions[bot] added the label wasmtime:ref-types on PR #13977.

Wasmtime GitHub notifications bot (Jul 25 2026 at 12:03):

github-actions[bot] added the label wasmtime:api on PR #13977.

Wasmtime GitHub notifications bot (Jul 25 2026 at 12:03):

github-actions[bot] commented on PR #13977:

Subscribe to Label Action

cc @fitzgen

<details>
This issue or pull request has been labeled: "wasmtime:api", "wasmtime:ref-types"

Thus the following users have been cc'd because of the following labels:

• fitzgen: wasmtime:ref-types

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Jul 27 2026 at 22:30):

:thumbs_up: fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Jul 27 2026 at 22:30):

fitzgen added PR #13977 fix(gc): restore trace_infos if worklist increment fails to the merge queue.

Wasmtime GitHub notifications bot (Jul 27 2026 at 23:04):

:check: fitzgen merged PR #13977.

Wasmtime GitHub notifications bot (Jul 27 2026 at 23:04):

fitzgen removed PR #13977 fix(gc): restore trace_infos if worklist increment fails from the merge queue.

Last updated: Jul 29 2026 at 05:03 UTC