Stream: git-wasmtime

Topic: wasmtime / PR #13953 Cranelift: simplify `DataValue::eq`

Wasmtime GitHub notifications bot (Jul 24 2026 at 12:56):

dev-er1 opened PR #13953 from dev-er1:simplify-datavalue-partialeq to bytecodealliance:main:

This simplifies the PartialEq implementation for DataValue by replacing the repeated ... => false match arms with a single wildcard arm.

No functional changes intended.

Wasmtime GitHub notifications bot (Jul 24 2026 at 12:56):

dev-er1 requested cfallin for a review on PR #13953.

Wasmtime GitHub notifications bot (Jul 24 2026 at 12:56):

dev-er1 requested wasmtime-compiler-reviewers for a review on PR #13953.

Wasmtime GitHub notifications bot (Jul 24 2026 at 13:30):

:thumbs_up: cfallin submitted PR review:

Thanks! Happy to merge once the rustfmt issue is fixed.

Wasmtime GitHub notifications bot (Jul 24 2026 at 13:43):

alexcrichton commented on PR #13953:

One possible note here is that this is an intentional idiom you'll find throughout Wasmtime in a number of places. The intentional part is that if a new variant is added the compiler's exhaustive-match checks flag the match as "gotta add more arms here". With a catch-all like proposed in this PR adding a new variant will get no such warnings and it'd be some bug later own down the road to force adding the match. Personally I find that more valuable than removing lines, but that's also a subjective call

Wasmtime GitHub notifications bot (Jul 24 2026 at 14:08):

:cross_mark: cfallin closed without merge PR #13953.

Wasmtime GitHub notifications bot (Jul 24 2026 at 14:08):

cfallin commented on PR #13953:

Ah, yeah, sorry, I should've registered that here -- brain saw wildcard -> wildcard and I missed that. Thanks; @dev-er1 we'll close this as above.

Wasmtime GitHub notifications bot (Jul 24 2026 at 14:55):

dev-er1 commented on PR #13953:

In any case, thanks for the review.

Last updated: Jul 29 2026 at 05:03 UTC