macovedj opened PR #13948 from macovedj:winch-aarch64-v128-abi to bytecodealliance:main:
While observing which tests flip as we add simd instructions for https://github.com/bytecodealliance/wasmtime/issues/9925, it became clear that while the instructions become usable, the simd types still error
Unsupported Wasm Typewhen they appear in function signatures. I was able to reproduce the logic into_abi_operandfrom the x64 implementation to use vector registers and larger stack slots for V128. This removes the error from the included .wat files, and flips a number of tests that should have flipped from the simd instructions that have been implemented so far.
macovedj requested cfallin for a review on PR #13948.
macovedj requested wasmtime-compiler-reviewers for a review on PR #13948.
macovedj requested wasmtime-core-reviewers for a review on PR #13948.
:thumbs_up: cfallin submitted PR review.
cfallin added PR #13948 winch(aarch64): v128 ABI plumbing to the merge queue.
github-merge-queue[bot] removed PR #13948 winch(aarch64): v128 ABI plumbing from the merge queue.
alexcrichton added PR #13948 winch(aarch64): v128 ABI plumbing to the merge queue.
github-actions[bot] added the label winch on PR #13948.
github-actions[bot] commented on PR #13948:
Subscribe to Label Action
cc @saulecabrera
<details>
This issue or pull request has been labeled: "winch"Thus the following users have been cc'd because of the following labels:
- saulecabrera: winch
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
github-merge-queue[bot] removed PR #13948 winch(aarch64): v128 ABI plumbing from the merge queue.
alexcrichton commented on PR #13948:
ok that one ^ seems legitimate (unlike so many others :cry:)
macovedj updated PR #13948.
alexcrichton added PR #13948 winch(aarch64): v128 ABI plumbing to the merge queue.
:check: alexcrichton merged PR #13948.
alexcrichton removed PR #13948 winch(aarch64): v128 ABI plumbing from the merge queue.
Last updated: Jul 29 2026 at 05:03 UTC