Stream: git-wasmtime

Topic: wasmtime / PR #13911 winch(aarch64): add v128.const support

view this post on Zulip Wasmtime GitHub notifications bot (Jul 20 2026 at 22:30):

macovedj opened PR #13911 from macovedj:winch-aarch64-v128-const to bytecodealliance:main:

This pr adds support for v128.const to winch for aarch64.

I'd like to tackle the larger list of missing SIMD support, and figured I should start with something small.

In mov_ir the v128 immediate takes the add_constant path rather than the emit path since that's what the x64 backend does for these load_fp_const.

If this goes through I could go ahead and tackle the rest of v128, followed by the others.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 20 2026 at 22:30):

macovedj requested cfallin for a review on PR #13911.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 20 2026 at 22:30):

macovedj requested wasmtime-core-reviewers for a review on PR #13911.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 20 2026 at 22:30):

macovedj requested wasmtime-compiler-reviewers for a review on PR #13911.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 20 2026 at 22:35):

:thumbs_up: cfallin submitted PR review:

LGTM, thanks!

There's a warning now about the now-unused UnsupportedImm error -- CI should be green once that's removed, then I'm happy to merge.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 20 2026 at 22:40):

macovedj updated PR #13911.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 20 2026 at 22:57):

macovedj commented on PR #13911:

LGTM, thanks!

There's a warning now about the now-unused UnsupportedImm error -- CI should be green once that's removed, then I'm happy to merge.

Thanks! Hope to have some more up soon!

view this post on Zulip Wasmtime GitHub notifications bot (Jul 21 2026 at 00:02):

github-actions[bot] added the label winch on PR #13911.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 21 2026 at 00:02):

github-actions[bot] commented on PR #13911:

Subscribe to Label Action

cc @saulecabrera

<details>
This issue or pull request has been labeled: "winch"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (Jul 21 2026 at 00:06):

cfallin added PR #13911 winch(aarch64): add v128.const support to the merge queue.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 21 2026 at 00:30):

github-merge-queue[bot] removed PR #13911 winch(aarch64): add v128.const support from the merge queue.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 21 2026 at 14:46):

macovedj updated PR #13911.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 21 2026 at 14:49):

macovedj commented on PR #13911:

Looks like there was another CI failure from expecting v128_load_lane_invalid_address to fail, which passes with v128.const support. Getting rid of the blanket simd should-fail check only required adding two additional tests to the unsupported list, so I figured the change I push lets me remove expected failures from the unsupported list as I go.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 21 2026 at 14:51):

macovedj edited a comment on PR #13911:

Looks like there was another CI failure from expecting v128_load_lane_invalid_address to fail, which passes with v128.const support. Getting rid of the blanket simd should-fail check only required adding two additional tests to the unsupported list, so I figured the change I pushed lets me remove expected failures from the unsupported list as I go.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 21 2026 at 14:58):

cfallin added PR #13911 winch(aarch64): add v128.const support to the merge queue.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 21 2026 at 15:23):

github-merge-queue[bot] removed PR #13911 winch(aarch64): add v128.const support from the merge queue.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 21 2026 at 15:41):

macovedj updated PR #13911.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 21 2026 at 15:45):

macovedj commented on PR #13911:

Looks like the simd check is also used by other test suites. Removing it caused a couple of tests/all winch tests to fail in the merge queue. Added it back and moved the wast exceptions to a now_supported list instead. As far as I can tell there's no way to avoid keeping that list and manually moving items over from unsupported as they start passing, but happy to change the approach if there's a better one.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 22 2026 at 18:42):

:thumbs_up: cfallin submitted PR review:

test-runner fixes LGTM; thanks!

view this post on Zulip Wasmtime GitHub notifications bot (Jul 22 2026 at 18:42):

cfallin added PR #13911 winch(aarch64): add v128.const support to the merge queue.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 22 2026 at 19:19):

:check: cfallin merged PR #13911.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 22 2026 at 19:19):

cfallin removed PR #13911 winch(aarch64): add v128.const support from the merge queue.

Last updated: Jul 29 2026 at 05:03 UTC