Stream: git-wasmtime

Topic: wasmtime / PR #13886 [CI] handle wasi-nn CI flaky tests

Wasmtime GitHub notifications bot (Jul 15 2026 at 23:41):

rahulchaphalkar opened PR #13886 from rahulchaphalkar:fix-ci-wasi-nn to bytecodealliance:main:

• changed panic! to bail! in download() and .lock().unwrap() to .lock().unwrap_or_else(|e| e.into_inner()) in wasi-nn backends. This isolates error caused by a DNS failure in one thread, and not allow it to poison other threads running other tests, example.
• Added retries to download() to in an attempt to resolve intermittent network issues reaching the server, example

(This is a draft PR for now, want to see whats happening with CI failures in Windows like here with illegal instruction)

Wasmtime GitHub notifications bot (Jul 16 2026 at 15:21):

alexcrichton commented on PR #13886:

Thanks! FWIW this looks good to me :+1:

Wasmtime GitHub notifications bot (Jul 16 2026 at 18:34):

rahulchaphalkar has marked PR #13886 as ready for review.

Wasmtime GitHub notifications bot (Jul 16 2026 at 18:34):

rahulchaphalkar requested pchickey for a review on PR #13886.

Wasmtime GitHub notifications bot (Jul 16 2026 at 18:34):

rahulchaphalkar requested wasmtime-wasi-reviewers for a review on PR #13886.

Wasmtime GitHub notifications bot (Jul 16 2026 at 18:35):

rahulchaphalkar commented on PR #13886:

I will create a separate PR for windows runner failures soon, this PR addresses network issues.

Wasmtime GitHub notifications bot (Jul 16 2026 at 18:35):

rahulchaphalkar edited PR #13886:

• changed panic! to bail! in download() and .lock().unwrap() to .lock().unwrap_or_else(|e| e.into_inner()) in wasi-nn backends. This isolates error caused by a DNS failure in one thread, and not allow it to poison other threads running other tests, example.
• Added retries to download() to in an attempt to resolve intermittent network issues reaching the server, example

Edit - Ready for review

Wasmtime GitHub notifications bot (Jul 16 2026 at 18:41):

:thumbs_up: alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Jul 16 2026 at 18:41):

alexcrichton added PR #13886 [CI] handle wasi-nn CI flaky tests to the merge queue.

Wasmtime GitHub notifications bot (Jul 16 2026 at 19:06):

:check: alexcrichton merged PR #13886.

Wasmtime GitHub notifications bot (Jul 16 2026 at 19:06):

alexcrichton removed PR #13886 [CI] handle wasi-nn CI flaky tests from the merge queue.

Last updated: Jul 29 2026 at 05:03 UTC