Stream: git-wasmtime

Topic: wasmtime / PR #13810 Refactor wasip2 http host trait to l...

Wasmtime GitHub notifications bot (Jul 02 2026 at 23:22):

alexcrichton requested dicej for a review on PR #13810.

Wasmtime GitHub notifications bot (Jul 02 2026 at 23:22):

alexcrichton requested wasmtime-wasi-reviewers for a review on PR #13810.

Wasmtime GitHub notifications bot (Jul 02 2026 at 23:22):

alexcrichton opened PR #13810 from alexcrichton:refactor-http to bytecodealliance:main:

This commit is made in preparation for eventually merging the WasiHttpHooks traits of the p2 and p3 modules to ensure that they're handled uniformly across the crate. This'll pave the way for future refactoring such as only handling one default_send_request and more uniform handling of HTTP headers. These traits are not merged yet, however, and the goal of this commit is to resolve a major point of divergence: the send_request method. This commit changes the wasip2 signature to instead look like the wasip3 signature.

One change made in this commit as a result is that the between-bytes-timeout is now only handled by default in default_send_request instead of unconditionally wrapping whatever the host generated. This is in-line with what wasip3 does, for example.

Much of this commit is juggling types around to get things to line up, so various signatures/etc were all refactored along the way.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Jul 03 2026 at 03:10):

alexcrichton updated PR #13810.

Wasmtime GitHub notifications bot (Jul 06 2026 at 15:03):

:thumbs_up: dicej submitted PR review.

Wasmtime GitHub notifications bot (Jul 06 2026 at 15:04):

alexcrichton added PR #13810 Refactor wasip2 http host trait to look like wasip3 to the merge queue.

Wasmtime GitHub notifications bot (Jul 06 2026 at 15:29):

:check: alexcrichton merged PR #13810.

Wasmtime GitHub notifications bot (Jul 06 2026 at 15:29):

alexcrichton removed PR #13810 Refactor wasip2 http host trait to look like wasip3 from the merge queue.

Last updated: Jul 29 2026 at 05:03 UTC