alexcrichton requested dicej for a review on PR #13807.
alexcrichton requested wasmtime-wasi-reviewers for a review on PR #13807.
alexcrichton opened PR #13807 from alexcrichton:refactor-http-slightly to bytecodealliance:main:
- Use futures when creating a
FutureReaderrather than implementingFutureProducerdirectly.- Use a helper of run-with-callback to avoid manual impls of
FutureConsumer.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
:thumbs_up: dicej submitted PR review.
:speech_balloon: dicej created PR review comment:
FYI, I did something a bit more general here for https://github.com/spinframework/spin/issues/3566. Maybe I should upstream that?
:memo: alexcrichton submitted PR review.
:speech_balloon: alexcrichton created PR review comment:
This is a bit different than that where this isn't producing a new future it's just running some code with the result ready, so I don't think that'd be a direct replacement for this but having utilities like that upstream (and perhaps this in the
wasmtimecrate) I do think would be useful.
alexcrichton added PR #13807 Reduce some complexity in wasi-http p3 paths to the merge queue.
:check: alexcrichton merged PR #13807.
alexcrichton removed PR #13807 Reduce some complexity in wasi-http p3 paths from the merge queue.
Last updated: Jul 29 2026 at 05:03 UTC