Wasmtime GitHub notifications bot (Mar 21 2020 at 13:06): Wasmtime GitHub notifications bot (Mar 21 2020 at 13:06):jjsullivan5196 opened PR #1378 from doc-python-guide to master:
Adding python usage documentation for the book #1272
Goes over the first two examples in the python binding crate, linking to source code and necessary tools. I initially wanted to do a markdown parser example, but it's a little tricky with interface types removed. I'm making this PR just to get some basics covered.
Wasmtime GitHub notifications bot (Mar 21 2020 at 13:18):jjsullivan5196 updated PR #1378 from doc-python-guide to master:
Adding python usage documentation for the book #1272
Goes over the first two examples in the python binding crate, linking to source code and necessary tools. I initially wanted to do a markdown parser example, but it's a little tricky with interface types removed. I'm making this PR just to get some basics covered.
Wasmtime GitHub notifications bot (Mar 21 2020 at 13:49):jjsullivan5196 updated PR #1378 from doc-python-guide to master:
Adding python usage documentation for the book #1272
Goes over the first two examples in the python binding crate, linking to source code and necessary tools. I initially wanted to do a markdown parser example, but it's a little tricky with interface types removed. I'm making this PR just to get some basics covered.
Wasmtime GitHub notifications bot (Mar 22 2020 at 08:37):samrat submitted PR Review.
Wasmtime GitHub notifications bot (Mar 22 2020 at 08:37):samrat created PR Review Comment:
This is missing the filename:
> rustup run nightly rustc --target=wasm32-unknown-unknown --crate-type=cdylib demo.rs
Wasmtime GitHub notifications bot (Mar 22 2020 at 09:29):jjsullivan5196 submitted PR Review.
Wasmtime GitHub notifications bot (Mar 22 2020 at 09:29):jjsullivan5196 created PR Review Comment:
Ah, I'll fix that
Wasmtime GitHub notifications bot (Mar 22 2020 at 09:30):jjsullivan5196 edited PR Review Comment.
Wasmtime GitHub notifications bot (Mar 22 2020 at 09:31):jjsullivan5196 updated PR #1378 from doc-python-guide to master:
Adding python usage documentation for the book #1272
Goes over the first two examples in the python binding crate, linking to source code and necessary tools. I initially wanted to do a markdown parser example, but it's a little tricky with interface types removed. I'm making this PR just to get some basics covered.
Wasmtime GitHub notifications bot (Mar 23 2020 at 14:10):alexcrichton submitted PR Review.
Wasmtime GitHub notifications bot (Mar 23 2020 at 14:10):alexcrichton created PR Review Comment:
How come this was adjusted? I think the
rustc +channelis a bit more terse and idiomatic thanrustup run, although these should both be equivalent.
Wasmtime GitHub notifications bot (Mar 23 2020 at 14:10):alexcrichton submitted PR Review.
Wasmtime GitHub notifications bot (Mar 23 2020 at 14:10):alexcrichton created PR Review Comment:
I think these will want to be surrounded in three ticks (\`) instead of with a
>because I believe that's a blockquote?e.g.
wat2wasm gcd.watvs
wat2wasm gcd.wat
Wasmtime GitHub notifications bot (Mar 23 2020 at 14:10):alexcrichton created PR Review Comment:
This can probably be dropped now
Wasmtime GitHub notifications bot (Mar 24 2020 at 00:34):jjsullivan5196 created PR Review Comment:
The
rustc +channel ...didn't work on my box (it just added another compilation unit+channel) I'd be fine with reverting this if it's a just my box thing
Wasmtime GitHub notifications bot (Mar 24 2020 at 00:34):jjsullivan5196 submitted PR Review.
Wasmtime GitHub notifications bot (Mar 24 2020 at 00:36):jjsullivan5196 updated PR #1378 from doc-python-guide to master:
Adding python usage documentation for the book #1272
Goes over the first two examples in the python binding crate, linking to source code and necessary tools. I initially wanted to do a markdown parser example, but it's a little tricky with interface types removed. I'm making this PR just to get some basics covered.
Wasmtime GitHub notifications bot (Mar 24 2020 at 00:38):jjsullivan5196 submitted PR Review.
Wasmtime GitHub notifications bot (Mar 24 2020 at 00:38):jjsullivan5196 created PR Review Comment:
Sounds good, fixed it
Wasmtime GitHub notifications bot (Mar 24 2020 at 00:38):jjsullivan5196 submitted PR Review.
Wasmtime GitHub notifications bot (Mar 24 2020 at 00:38):jjsullivan5196 created PR Review Comment:
Got it :+1:
Wasmtime GitHub notifications bot (Mar 24 2020 at 00:56):alexcrichton created PR Review Comment:
Hm are you sure you have rust installed correctly? It sounds like you have a
rustcinPATHwhich isn't rustup-managed?
Wasmtime GitHub notifications bot (Mar 24 2020 at 00:56):alexcrichton submitted PR Review.
Wasmtime GitHub notifications bot (Mar 24 2020 at 03:06):jjsullivan5196 submitted PR Review.
Wasmtime GitHub notifications bot (Mar 24 2020 at 03:06):jjsullivan5196 created PR Review Comment:
Ah, that's the reason. I installed the toolchain thru the mozilla nix overlay, so it's probably just the bare compiler. I'll revert this commit. https://github.com/mozilla/nixpkgs-mozilla
Wasmtime GitHub notifications bot (Mar 24 2020 at 03:11):jjsullivan5196 updated PR #1378 from doc-python-guide to master:
Adding python usage documentation for the book #1272
Goes over the first two examples in the python binding crate, linking to source code and necessary tools. I initially wanted to do a markdown parser example, but it's a little tricky with interface types removed. I'm making this PR just to get some basics covered.
Wasmtime GitHub notifications bot (Mar 24 2020 at 04:41):jjsullivan5196 updated PR #1378 from doc-python-guide to master:
Adding python usage documentation for the book #1272
Goes over the first two examples in the python binding crate, linking to source code and necessary tools. I initially wanted to do a markdown parser example, but it's a little tricky with interface types removed. I'm making this PR just to get some basics covered.
Wasmtime GitHub notifications bot (Mar 24 2020 at 14:44):alexcrichton merged PR #1378.
Last updated: Nov 22 2024 at 16:03 UTC