Stream: git-wasmtime

Topic: wasmtime / PR #1371 [wiggle] Don't make generated structs...

Wasmtime GitHub notifications bot (Mar 20 2020 at 22:14):

sunfishcode opened PR #1371 from no-struct-copy to master:

Some structs and unions are large enough that making them Copy isn't
ideal. wasi-common only needed Copy in a few places that were easy to
fix. SubscriptionClock is 32 bytes, so it's not a bad a idea to pass
it by reference anyway.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Mar 20 2020 at 22:55):

peterhuene submitted PR Review.

Wasmtime GitHub notifications bot (Mar 23 2020 at 17:01):

kubkon merged PR #1371.

Last updated: Nov 22 2024 at 16:03 UTC