Wasmtime GitHub notifications bot (Jun 18 2026 at 15:58): Wasmtime GitHub notifications bot (Jun 18 2026 at 15:58):fitzgen opened PR #13689 from fitzgen:trap-blocks-are-cold to bytecodealliance:main:
These blocks cannot be part of hot loops, as they terminate control.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Jun 18 2026 at 15:58):fitzgen requested wasmtime-compiler-reviewers for a review on PR #13689.
Wasmtime GitHub notifications bot (Jun 18 2026 at 15:58):fitzgen requested wasmtime-core-reviewers for a review on PR #13689.
Wasmtime GitHub notifications bot (Jun 18 2026 at 15:58):fitzgen requested cfallin for a review on PR #13689.
Wasmtime GitHub notifications bot (Jun 18 2026 at 19:14)::thumbs_up: cfallin submitted PR review.
Wasmtime GitHub notifications bot (Jun 18 2026 at 19:14)::speech_balloon: cfallin created PR review comment:
The blockorder algorithm implementation is the wrong place to hide this logic, IMHO -- it's otherwise a low-level and generic algorithm. Maybe an
f.is_effectively_cold(block)helper that encodes this logic would be better?
Wasmtime GitHub notifications bot (Jun 18 2026 at 20:32):github-actions[bot] added the label cranelift:area:machinst on PR #13689.
Wasmtime GitHub notifications bot (Jun 18 2026 at 20:32):github-actions[bot] added the label cranelift on PR #13689.
Wasmtime GitHub notifications bot (Jun 18 2026 at 20:36):fitzgen updated PR #13689.
Wasmtime GitHub notifications bot (Jun 18 2026 at 20:36)::memo: fitzgen submitted PR review.
Wasmtime GitHub notifications bot (Jun 18 2026 at 20:36)::speech_balloon: fitzgen created PR review comment:
Good call, done in https://github.com/bytecodealliance/wasmtime/pull/13689/commits/c71e7ff3e8e43a569e1ae3b2add7b3915e880a94
Wasmtime GitHub notifications bot (Jun 18 2026 at 20:36):fitzgen has enabled auto merge for PR #13689.
Wasmtime GitHub notifications bot (Jun 18 2026 at 20:48):fitzgen added PR #13689 Cranelift: implicitly consider trapping blocks as "cold" during lowering to the merge queue.
Wasmtime GitHub notifications bot (Jun 18 2026 at 21:13)::check: fitzgen merged PR #13689.
Wasmtime GitHub notifications bot (Jun 18 2026 at 21:13):fitzgen removed PR #13689 Cranelift: implicitly consider trapping blocks as "cold" during lowering from the merge queue.
Last updated: Jul 29 2026 at 05:03 UTC