Stream: git-wasmtime

Topic: wasmtime / PR #13667 Do not use `ir::GlobalValue` in Wasm...

Wasmtime GitHub notifications bot (Jun 16 2026 at 17:57):

fitzgen opened PR #13667 from fitzgen:no-globals-in-memory-translation to bytecodealliance:main:

Instead, define a new VmctxLoadChain type which describes a chain of loads starting from the vmctx and which ultimately reaches a memory's base or bound. This will also be reused for table bases and bounds in a future commit.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Jun 16 2026 at 17:57):

fitzgen requested cfallin for a review on PR #13667.

Wasmtime GitHub notifications bot (Jun 16 2026 at 17:57):

fitzgen requested wasmtime-compiler-reviewers for a review on PR #13667.

Wasmtime GitHub notifications bot (Jun 16 2026 at 17:57):

fitzgen requested wasmtime-core-reviewers for a review on PR #13667.

Wasmtime GitHub notifications bot (Jun 16 2026 at 18:31):

:thumbs_up: cfallin submitted PR review:

Nice cleanup!

Wasmtime GitHub notifications bot (Jun 16 2026 at 18:31):

:speech_balloon: cfallin created PR review comment:

From a mini-language-design point of view: why not permit an empty list? Wouldn't that mean "vmctx itself"?

(May not have a actual use so I'm fine constraining this, just curious if there was a deeper reason or contradiction here)

Wasmtime GitHub notifications bot (Jun 16 2026 at 20:25):

:memo: fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Jun 16 2026 at 20:25):

:speech_balloon: fitzgen created PR review comment:

Just that we never use it for that purpose, so I didn't want to accidentally have it slip in. Easy to adjust later if we find a need to.

Wasmtime GitHub notifications bot (Jun 16 2026 at 20:28):

fitzgen updated PR #13667.

Wasmtime GitHub notifications bot (Jun 16 2026 at 20:28):

fitzgen has enabled auto merge for PR #13667.

Wasmtime GitHub notifications bot (Jun 16 2026 at 20:39):

fitzgen added PR #13667 Do not use ir::GlobalValue in Wasm memory translation to the merge queue.

Wasmtime GitHub notifications bot (Jun 16 2026 at 21:08):

:check: fitzgen merged PR #13667.

Wasmtime GitHub notifications bot (Jun 16 2026 at 21:08):

fitzgen removed PR #13667 Do not use ir::GlobalValue in Wasm memory translation from the merge queue.

Last updated: Jul 29 2026 at 05:03 UTC