Stream: git-wasmtime

Topic: wasmtime / PR #1366 [wiggle] Allow for zero-length wiggle...

view this post on Zulip Wasmtime GitHub notifications bot (Mar 20 2020 at 10:32):

kubkon opened PR #1366 from wiggle-zero-len-regions to master:

Previously, we'd be very strict and disallow zero-length wiggle_runtime::Regions
altogether (we'd actually panic which is even worse). However, we
should allow this noting that any zero-length Region never
overlaps since its length is, well, zero. Additionally, this makes
path_readlink with zero buffers cleaner and possible without
additional checks/hacks around the passed in GuestPtr<'_, [u8]>
buffer.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 20 2020 at 10:32):

kubkon requested alexcrichton, and pchickey for a review on PR #1366.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 20 2020 at 10:32):

kubkon requested alexcrichton, and pchickey for a review on PR #1366.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 20 2020 at 14:35):

alexcrichton submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 20 2020 at 14:35):

alexcrichton merged PR #1366.

Last updated: Nov 22 2024 at 16:03 UTC