Stream: git-wasmtime

Topic: wasmtime / PR #13658 Tag all `VMStoreContext` field loads...

Wasmtime GitHub notifications bot (Jun 15 2026 at 18:20):

fitzgen opened PR #13658 from fitzgen:VMStoreContext-alias-regions to bytecodealliance:main:

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Jun 15 2026 at 18:20):

fitzgen requested cfallin for a review on PR #13658.

Wasmtime GitHub notifications bot (Jun 15 2026 at 18:20):

fitzgen requested wasmtime-compiler-reviewers for a review on PR #13658.

Wasmtime GitHub notifications bot (Jun 15 2026 at 18:20):

fitzgen requested wasmtime-core-reviewers for a review on PR #13658.

Wasmtime GitHub notifications bot (Jun 16 2026 at 19:13):

:memo: cfallin submitted PR review:

Something I want to double-check below but the general approach seems OK:

Wasmtime GitHub notifications bot (Jun 16 2026 at 19:13):

:speech_balloon: cfallin created PR review comment:

Ah, this may contradict my point above?

Wasmtime GitHub notifications bot (Jun 16 2026 at 19:13):

:speech_balloon: cfallin created PR review comment:

I was pretty confused at first seeing this bare memflags (no region) used with data structure accesses below, and the generic name "our memflags"; perhaps stack_limits_memflags and comment that the VMStackLimits struct does not use regions? (And for the future: should it?)

Wasmtime GitHub notifications bot (Jun 16 2026 at 22:30):

:memo: fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Jun 16 2026 at 22:30):

:speech_balloon: fitzgen created PR review comment:

Yes, VMStackLimits will eventually use its own alias region, but not for a few more commits. In the meantime, I've fixed up some naming and doc comments here, will push in a second.

Wasmtime GitHub notifications bot (Jun 16 2026 at 22:46):

fitzgen updated PR #13658.

Wasmtime GitHub notifications bot (Jun 16 2026 at 22:47):

:memo: fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Jun 16 2026 at 22:47):

:speech_balloon: fitzgen created PR review comment:

See https://github.com/bytecodealliance/wasmtime/pull/13658/commits/c9457de3dd7ca35dd9ff29c90ae05b8723a55a3d

Wasmtime GitHub notifications bot (Jun 16 2026 at 22:50):

:memo: cfallin submitted PR review.

Wasmtime GitHub notifications bot (Jun 16 2026 at 22:50):

:speech_balloon: cfallin created PR review comment:

Ah, OK, I missed the distinction there -- thanks.

Wasmtime GitHub notifications bot (Jun 16 2026 at 22:54):

:thumbs_up: cfallin submitted PR review.

Wasmtime GitHub notifications bot (Jun 16 2026 at 22:57):

fitzgen added PR #13658 Tag all VMStoreContext field loads/stores with alias regions to the merge queue.

Wasmtime GitHub notifications bot (Jun 16 2026 at 23:25):

:check: fitzgen merged PR #13658.

Wasmtime GitHub notifications bot (Jun 16 2026 at 23:25):

fitzgen removed PR #13658 Tag all VMStoreContext field loads/stores with alias regions from the merge queue.

Last updated: Jul 29 2026 at 05:03 UTC