Wasmtime GitHub notifications bot (Jun 15 2026 at 17:16): Wasmtime GitHub notifications bot (Jun 15 2026 at 17:16):alexcrichton opened PR #13655 from alexcrichton:remove-has-type-usage to bytecodealliance:main:
Prior refactorings added a type parameter to all instruction matchers and this refactoring starts using it in all the places that historically used
has_type.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Jun 15 2026 at 17:16):alexcrichton requested cfallin for a review on PR #13655.
Wasmtime GitHub notifications bot (Jun 15 2026 at 17:16):alexcrichton requested wasmtime-compiler-reviewers for a review on PR #13655.
Wasmtime GitHub notifications bot (Jun 15 2026 at 17:30)::memo: cfallin submitted PR review:
I skimmed over / spot-checked since there are so many mechanical conversions, but the ones I examined all look right to me and test outputs don't change so :+1:
Wasmtime GitHub notifications bot (Jun 15 2026 at 17:30)::thumbs_up: cfallin submitted PR review.
Wasmtime GitHub notifications bot (Jun 15 2026 at 17:30):cfallin has enabled auto merge for PR #13655.
Wasmtime GitHub notifications bot (Jun 15 2026 at 17:32):cfallin added PR #13655 Remove most usage of has_type in ISLE backends to the merge queue.
Wasmtime GitHub notifications bot (Jun 15 2026 at 17:58)::check: cfallin merged PR #13655.
Wasmtime GitHub notifications bot (Jun 15 2026 at 17:58):cfallin removed PR #13655 Remove most usage of has_type in ISLE backends from the merge queue.
Last updated: Jul 29 2026 at 05:03 UTC