Stream: git-wasmtime

Topic: wasmtime / PR #13654 Flush stdout on every chunk accepted...

view this post on Zulip Wasmtime GitHub notifications bot (Jun 15 2026 at 17:03):

andreiltd opened PR #13654 from andreiltd:stdout-flush to bytecodealliance:main:

This is aggresive and it may be more flushing than necessary.

See: https://bytecodealliance.zulipchat.com/#narrow/channel/219900-wasi/topic/Flushing.20stdout.20in.20wasi.2Fp3/with/603401415

view this post on Zulip Wasmtime GitHub notifications bot (Jun 15 2026 at 17:04):

andreiltd requested pchickey for a review on PR #13654.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 15 2026 at 17:04):

andreiltd requested wasmtime-wasi-reviewers for a review on PR #13654.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 15 2026 at 17:04):

andreiltd requested wasmtime-core-reviewers for a review on PR #13654.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 15 2026 at 17:04):

andreiltd converted PR #13654 Flush stdout on every chunk accepted from the p3 stream to a draft.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 15 2026 at 18:06):

:thumbs_up: alexcrichton submitted PR review:

Thanks!

view this post on Zulip Wasmtime GitHub notifications bot (Jun 15 2026 at 18:06):

:speech_balloon: alexcrichton created PR review comment:

This'll want to handle the case of if finish which returns StreamResult::Cancelled instead. That'll additionally apply to the block below, too.

While you're here, the block at this location and below look more-or-less the same. Would it be possible to delegate everything into a helper method or fall-through?

view this post on Zulip Wasmtime GitHub notifications bot (Jun 15 2026 at 19:53):

andreiltd updated PR #13654.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 15 2026 at 19:53):

andreiltd has marked PR #13654 as ready for review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 15 2026 at 19:56):

:memo: alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 15 2026 at 19:56):

:speech_balloon: alexcrichton created PR review comment:

Oh this can stay as-is. When finish is true it just means "try not to block" but it's more faithful to say "completed" than "cancelled"

view this post on Zulip Wasmtime GitHub notifications bot (Jun 15 2026 at 19:56):

:speech_balloon: alexcrichton created PR review comment:

Since these helpers are only called from above, can the bodies be inlined up there?

view this post on Zulip Wasmtime GitHub notifications bot (Jun 15 2026 at 19:57):

:memo: andreiltd submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 15 2026 at 19:57):

:speech_balloon: andreiltd created PR review comment:

Gotcha!

view this post on Zulip Wasmtime GitHub notifications bot (Jun 15 2026 at 20:08):

andreiltd updated PR #13654.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 15 2026 at 20:12):

:thumbs_up: alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 15 2026 at 20:12):

alexcrichton has enabled auto merge for PR #13654.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 15 2026 at 20:19):

alexcrichton added PR #13654 Flush stdout on every chunk accepted from the p3 stream to the merge queue.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 15 2026 at 20:45):

alexcrichton removed PR #13654 Flush stdout on every chunk accepted from the p3 stream from the merge queue.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 15 2026 at 21:13):

:check: alexcrichton merged PR #13654.

Last updated: Jul 29 2026 at 05:03 UTC