Wasmtime GitHub notifications bot (Mar 19 2020 at 21:02): Wasmtime GitHub notifications bot (Mar 19 2020 at 21:02):alexcrichton opened PR #1365 from no-cpp to master:
This commit removes the last wads of C++ that we have in wasmtime,
meaning that building wasmtime no longer requires a C++ compiler. It
still does require a C toolchain for some minor purposes, but hopefully
we can remove that over time too!The motivation for doing this is to consolidate all our signal-handling
code into one location in one language so you don't have to keep
crossing back and forth when understanding what's going on. This also
allows us to remove some extra cruft that wasn't necessary from the C++
original implementation. Additionally this should also make building
wasmtime a bit more portable since it's often easier to acquire a C
toolchain than it is to acquire a C++ toolchain. (e.g. if you're
cross-compiling to a musl target)
Wasmtime GitHub notifications bot (Mar 20 2020 at 16:24):pepyakin submitted PR Review.
Wasmtime GitHub notifications bot (Mar 20 2020 at 16:24):pepyakin submitted PR Review.
Wasmtime GitHub notifications bot (Mar 20 2020 at 16:24):pepyakin created PR Review Comment:
isn't this a signal for
signal?
Wasmtime GitHub notifications bot (Mar 20 2020 at 16:24):pepyakin created PR Review Comment:
Why do we want to reset the handling_trap flag here? It seems that
handle_trapalready takes care about this and windows version doesn't do this either.
Wasmtime GitHub notifications bot (Mar 20 2020 at 16:27):alexcrichton updated PR #1365 from no-cpp to master:
This commit removes the last wads of C++ that we have in wasmtime,
meaning that building wasmtime no longer requires a C++ compiler. It
still does require a C toolchain for some minor purposes, but hopefully
we can remove that over time too!The motivation for doing this is to consolidate all our signal-handling
code into one location in one language so you don't have to keep
crossing back and forth when understanding what's going on. This also
allows us to remove some extra cruft that wasn't necessary from the C++
original implementation. Additionally this should also make building
wasmtime a bit more portable since it's often easier to acquire a C
toolchain than it is to acquire a C++ toolchain. (e.g. if you're
cross-compiling to a musl target)
Wasmtime GitHub notifications bot (Mar 20 2020 at 16:28):alexcrichton submitted PR Review.
Wasmtime GitHub notifications bot (Mar 20 2020 at 16:28):alexcrichton created PR Review Comment:
Oops my mistake, forgot to move this when refactoring.
Wasmtime GitHub notifications bot (Mar 20 2020 at 18:52):sunfishcode submitted PR Review.
Wasmtime GitHub notifications bot (Mar 20 2020 at 20:21):alexcrichton merged PR #1365.
Last updated: Nov 22 2024 at 17:03 UTC