Stream: git-wasmtime

Topic: wasmtime / PR #13644 [24.0.x] Fix leak in `fd_renumber`

Wasmtime GitHub notifications bot (Jun 15 2026 at 14:32):

alexcrichton opened PR #13644 from alexcrichton:back24 to bytecodealliance:release-24.0.0:

This commit fixes a file descriptor leak in the WASIp1 implementation of
fd_renumber in the wasmtime-wasi crate. Notably the previous
implementation did not fully close the file descriptor being
renumbered-to which meant that the host's resources for the file,
including the file descriptor, stayed alive. The fix here is to validate
both fds exist and then delegate to the fd_close call to close the
destination.

This additionally updates the behavior of fd_renumber when renumbering
to fds that weren't previously open to match the main branch which
notably rejects these calls.

Wasmtime GitHub notifications bot (Jun 15 2026 at 14:32):

alexcrichton requested wasmtime-core-reviewers for a review on PR #13644.

Wasmtime GitHub notifications bot (Jun 15 2026 at 14:32):

alexcrichton requested pchickey for a review on PR #13644.

Wasmtime GitHub notifications bot (Jun 15 2026 at 14:32):

alexcrichton requested fitzgen for a review on PR #13644.

Wasmtime GitHub notifications bot (Jun 15 2026 at 14:32):

alexcrichton requested wasmtime-default-reviewers for a review on PR #13644.

Wasmtime GitHub notifications bot (Jun 15 2026 at 14:38):

alexcrichton updated PR #13644.

Wasmtime GitHub notifications bot (Jun 15 2026 at 16:24):

:thumbs_up: dicej submitted PR review.

Wasmtime GitHub notifications bot (Jun 15 2026 at 16:26):

:check: alexcrichton merged PR #13644.

Last updated: Jul 29 2026 at 05:03 UTC