Wasmtime GitHub notifications bot (Jun 12 2026 at 22:30): Wasmtime GitHub notifications bot (Jun 12 2026 at 22:30):fitzgen opened PR #13627 from fitzgen:VMContext-alias-regions-followup to bytecodealliance:main:
These helpers always use the correct flags and region.
Eventually there will be helper methods for all our other
VM*types as well.Ideally we would mechanically generate all this stuff, and the
VM*type definitions, and the offset calculation from the same single source of truth via fancy macros or whatever. Haven't fully thought through that yet, but one day. In the meantime, this prevents accidental bugs due to using incorrect flags and regions.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Jun 12 2026 at 22:30):fitzgen requested cfallin for a review on PR #13627.
Wasmtime GitHub notifications bot (Jun 12 2026 at 22:30):fitzgen requested wasmtime-compiler-reviewers for a review on PR #13627.
Wasmtime GitHub notifications bot (Jun 12 2026 at 22:30):fitzgen requested wasmtime-core-reviewers for a review on PR #13627.
Wasmtime GitHub notifications bot (Jun 12 2026 at 22:30):fitzgen commented on PR #13627:
@cfallin here is the follow up I promised based on your review comment in https://github.com/bytecodealliance/wasmtime/pull/13615
Wasmtime GitHub notifications bot (Jun 12 2026 at 22:56)::thumbs_up: cfallin submitted PR review:
Looks good -- thanks!
Wasmtime GitHub notifications bot (Jun 15 2026 at 16:36):fitzgen updated PR #13627.
Wasmtime GitHub notifications bot (Jun 15 2026 at 16:36):fitzgen has enabled auto merge for PR #13627.
Wasmtime GitHub notifications bot (Jun 15 2026 at 16:53):fitzgen updated PR #13627.
Wasmtime GitHub notifications bot (Jun 15 2026 at 17:03):fitzgen added PR #13627 Introduce helper methods for loading from VMContext to the merge queue
Wasmtime GitHub notifications bot (Jun 15 2026 at 17:27)::check: fitzgen merged PR #13627.
Wasmtime GitHub notifications bot (Jun 15 2026 at 17:27):fitzgen removed PR #13627 Introduce helper methods for loading from VMContext from the merge queue
Last updated: Jul 29 2026 at 05:03 UTC