Stream: git-wasmtime

Topic: wasmtime / PR #13620 feat: allow custom fiber API impls o...

view this post on Zulip Wasmtime GitHub notifications bot (Jun 12 2026 at 10:04):

rvolosatovs edited PR #13620.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 12 2026 at 10:12):

rvolosatovs updated PR #13620.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 12 2026 at 10:14):

:memo: rvolosatovs submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 12 2026 at 10:14):

:speech_balloon: rvolosatovs created PR review comment:

I'm not sure if this should be gated by custom feature, but the comment in stackswitch states:

   // No support for this platform. Don't fail compilation though and
   // instead defer the error to happen at runtime when a fiber is created.
   // Should help keep compiles working and narrows the failure to only
   // situations that need fibers on unsupported platforms.

so this seems consistent

view this post on Zulip Wasmtime GitHub notifications bot (Jun 12 2026 at 13:46):

github-actions[bot] added the label wasmtime:api on PR #13620.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 12 2026 at 15:17):

:memo: alexcrichton submitted PR review:

Sounds reasonable to me, thanks!

Structurally though I'd like to plumb this a bit differently to ensure this shows up in the wasmtime-platform.h header file. That header is generated from this file and is the current source-of-truth for "wasmtime may externally rely on these things" and provides a nice place to document things as well.

Now if these C API definitions were added over there they wouldn't actually be usable in wasmtime-internal-fiber due to crate dependencies, but that's also fine to have them duplicated here. Basically, can you add these function definitions over there, document them as to their purpose, leave a provisional comment in both locations saying "hey this is duplicated over there keep them in-sync", and then regenerate the header file?

view this post on Zulip Wasmtime GitHub notifications bot (Jun 12 2026 at 17:48):

pchickey unassigned pchickey from PR #13620 feat: allow custom fiber API impls on unsupported arches.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 18 2026 at 14:10):

rvolosatovs updated PR #13620.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 18 2026 at 14:11):

rvolosatovs requested alexcrichton for a review on PR #13620.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 18 2026 at 14:12):

rvolosatovs has enabled auto merge for PR #13620.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 18 2026 at 14:42):

:thumbs_up: alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 18 2026 at 14:42):

rvolosatovs added PR #13620 feat: allow custom fiber API impls on unsupported arches to the merge queue.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 18 2026 at 15:12):

:check: rvolosatovs merged PR #13620.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 18 2026 at 15:12):

rvolosatovs removed PR #13620 feat: allow custom fiber API impls on unsupported arches from the merge queue.

Last updated: Jul 29 2026 at 05:03 UTC