Stream: git-wasmtime

Topic: wasmtime / PR #13615 Tag all `VMContext` field accesses w...

Wasmtime GitHub notifications bot (Jun 11 2026 at 22:38):

fitzgen opened PR #13615 from fitzgen:VMContext-alias-regions to bytecodealliance:main:

Annotates the passive runtime-data length/base array loads/stores and the copying collector's gc-heap-data pointer load with the VMContext alias region, which were the only VMContext fields left that didn't use alias regions.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Jun 11 2026 at 22:38):

fitzgen requested cfallin for a review on PR #13615.

Wasmtime GitHub notifications bot (Jun 11 2026 at 22:38):

fitzgen requested wasmtime-core-reviewers for a review on PR #13615.

Wasmtime GitHub notifications bot (Jun 11 2026 at 22:44):

fitzgen requested wasmtime-compiler-reviewers for a review on PR #13615.

Wasmtime GitHub notifications bot (Jun 11 2026 at 22:47):

:thumbs_up: cfallin submitted PR review.

Wasmtime GitHub notifications bot (Jun 11 2026 at 22:47):

:speech_balloon: cfallin created PR review comment:

For all of these cases where we have a region specifically for an offset in vmctx, then we load from that offset, perhaps it would make sense to bundle together into a helper func_env.load_from_vmctx_offset(...) or somesuch so that we know it's correct (no copy/paste errors or whatever)?

Wasmtime GitHub notifications bot (Jun 12 2026 at 16:23):

:memo: fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Jun 12 2026 at 16:23):

:speech_balloon: fitzgen created PR review comment:

I'll do this in a follow up.

Wasmtime GitHub notifications bot (Jun 12 2026 at 16:23):

fitzgen added PR #13615 Tag all VMContext field accesses with alias regions to the merge queue.

Wasmtime GitHub notifications bot (Jun 12 2026 at 16:48):

github-merge-queue[bot] removed PR #13615 Tag all VMContext field accesses with alias regions from the merge queue.

Wasmtime GitHub notifications bot (Jun 12 2026 at 16:55):

fitzgen added PR #13615 Tag all VMContext field accesses with alias regions to the merge queue.

Wasmtime GitHub notifications bot (Jun 12 2026 at 17:30):

github-merge-queue[bot] removed PR #13615 Tag all VMContext field accesses with alias regions from the merge queue.

Wasmtime GitHub notifications bot (Jun 12 2026 at 17:40):

fitzgen added PR #13615 Tag all VMContext field accesses with alias regions to the merge queue.

Wasmtime GitHub notifications bot (Jun 12 2026 at 18:04):

github-merge-queue[bot] removed PR #13615 Tag all VMContext field accesses with alias regions from the merge queue.

Wasmtime GitHub notifications bot (Jun 12 2026 at 18:27):

alexcrichton added PR #13615 Tag all VMContext field accesses with alias regions to the merge queue.

Wasmtime GitHub notifications bot (Jun 12 2026 at 18:57):

:check: alexcrichton merged PR #13615.

Wasmtime GitHub notifications bot (Jun 12 2026 at 18:57):

alexcrichton removed PR #13615 Tag all VMContext field accesses with alias regions from the merge queue.

Last updated: Jul 29 2026 at 05:03 UTC