alexcrichton requested wasmtime-core-reviewers for a review on PR #13612.
alexcrichton requested wasmtime-wasi-reviewers for a review on PR #13612.
alexcrichton requested fitzgen for a review on PR #13612.
alexcrichton commented on PR #13612:
I'll additionally clarify that my intent is to backport this to the release-46.0.0 branch upon merging to
mainto have Wasmtime 46.0.0 be the first with component-model-async/WASIp3 support.
alexcrichton opened PR #13612 from alexcrichton:wasip3 to bytecodealliance:main:
This commit updates the vendored WASI WITs for the 0.3.0 release of WASI to this repository, updating the supported version of WASI that
wasmtime-wasiruns. This additionally enables thecomponent-model-asyncwasm feature by default in Wasmtime, along with-Sp3on the CLI as well. This is intended to be a comprehensive "turn WASI 0.3.0 on by default" PR which touches a few different locations.Apart from changing version numbers some minor changes made here are:
Default enablement of the wasm
cm-asyncfeature is now conditional onConfig::concurrency_supportin addition to the compile-time feature. This means that ifconcurrency_supportis disabled the default will be thatcm-asyncis disabled.The
tests/wasi.rstest suite running the upstreamwasi-testsuiterepository is updated to expect failures for all WASIp3 tests due to the import versions changing. This resulted in a necessary restructuring of the test to handle a few more failures in a few more locations to ensure that "should fail tests" are correctly marked as passing when they indeed do fail.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
alexcrichton requested wasmtime-default-reviewers for a review on PR #13612.
alexcrichton requested pchickey for a review on PR #13612.
alexcrichton updated PR #13612.
github-actions[bot] added the label wasmtime:api on PR #13612.
github-actions[bot] added the label wasi on PR #13612.
github-actions[bot] added the label wasmtime:config on PR #13612.
github-actions[bot] commented on PR #13612:
Label Messager: wasmtime:config
It looks like you are changing Wasmtime's configuration options. Make sure to
complete this check list:
[ ] If you added a new
Configmethod, you wrote extensive documentation for
it.<details>
Our documentation should be of the following form:
```text
Short, simple summary sentence.More details. These details can be multiple paragraphs. There should be
information about not just the method, but its parameters and results as
well.Is this method fallible? If so, when can it return an error?
Can this method panic? If so, when does it panic?
Example
Optional example here.
```</details>
[ ] If you added a new
Configmethod, or modified an existing one, you
ensured that this configuration is exercised by the fuzz targets.<details>
For example, if you expose a new strategy for allocating the next instance
slot inside the pooling allocator, you should ensure that at least one of our
fuzz targets exercises that new strategy.Often, all that is required of you is to ensure that there is a knob for this
configuration option in [wasmtime_fuzzing::Config][fuzzing-config] (or one
of its nestedstructs).Rarely, this may require authoring a new fuzz target to specifically test this
configuration. See [our docs on fuzzing][fuzzing-docs] for more details.</details>
[ ] If you are enabling a configuration option by default, make sure that it
has been fuzzed for at least two weeks before turning it on by default.[fuzzing-config]: https://github.com/bytecodealliance/wasmtime/blob/ca0e8d0a1d8cefc0496dba2f77a670571d8fdcab/crates/fuzzing/src/generators.rs#L182-L194
[fuzzing-docs]: https://docs.wasmtime.dev/contributing-fuzzing.html
<details>
To modify this label's message, edit the <code>.github/label-messager/wasmtime-config.md</code> file.
To add new label messages or remove existing label messages, edit the
<code>.github/label-messager.json</code> configuration file.</details>
:memo: ricochet submitted PR review:
One very minor nit, otherwise lgtm including handling exit-with-code
:speech_balloon: ricochet created PR review comment:
May want to update this comment now
:memo: pchickey submitted PR review.
:speech_balloon: pchickey created PR review comment:
This file is missing the changes from https://github.com/WebAssembly/WASI/pull/920/changes - not sure where along the chain those got missed
:memo: ricochet submitted PR review.
:speech_balloon: ricochet created PR review comment:
Note none of the inner wit doc comments are reflected in the resolved wit (old or new).
:memo: ricochet submitted PR review.
:speech_balloon: ricochet created PR review comment:
I see it on main: https://github.com/WebAssembly/WASI/blob/main/proposals/http/wit/worlds.wit#L35
None of the inner comments of the worlds are reflected here whether new or old.
:memo: ricochet submitted PR review.
:speech_balloon: ricochet created PR review comment:
This is a wasm-tools limitation where
WorldItem::Interfacedoesn't have a docs field so when going from wit to binary, we loose those docs. A doc comment on the service world would persist.
alexcrichton updated PR #13612.
:memo: alexcrichton submitted PR review.
:speech_balloon: alexcrichton created PR review comment:
Agreed yeah looks like this is a bug in wasm-tools, and thanks @ricochet for https://github.com/bytecodealliance/wasm-tools/pull/2540! In the meantime the docs here don't actually get plumbed anywhere else, so this is mostly just a minor in-repo thing for us in this vendoring.
:thumbs_up: pchickey submitted PR review.
:check: alexcrichton merged PR #13612.
alexcrichton removed PR #13612 Update WASI to 0.3.0, enable component-model-async from the merge queue.
alexcrichton added PR #13612 Update WASI to 0.3.0, enable component-model-async to the merge queue.
Last updated: Jul 29 2026 at 05:03 UTC