Stream: git-wasmtime

Topic: wasmtime / PR #13606 fix(tests): loosen p3 outbound conte...

Wasmtime GitHub notifications bot (Jun 10 2026 at 07:51):

vados-cosmonic opened PR #13606 from vados-cosmonic:fix(tests)=loosen-p3-async-http-content-length-acceptance-criteria to bytecodealliance:main:

This commit updates the test to allow for timings that match non-wasmtime implementations (i.e. Jco), which may not report the intermediate error (ErrorCode::HttpProtocolError) ahead of the "real" expected error (ErrorCode::HttpRequestBodySize)

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Jun 10 2026 at 07:51):

vados-cosmonic requested pchickey for a review on PR #13606.

Wasmtime GitHub notifications bot (Jun 10 2026 at 07:52):

vados-cosmonic requested wasmtime-core-reviewers for a review on PR #13606.

Wasmtime GitHub notifications bot (Jun 10 2026 at 07:52):

vados-cosmonic commented on PR #13606:

Special shout out to @rvolosatovs -- please let me know if I missed anything here intent-wise.

Wasmtime GitHub notifications bot (Jun 10 2026 at 08:00):

:memo: rvolosatovs submitted PR review.

Wasmtime GitHub notifications bot (Jun 10 2026 at 08:00):

:speech_balloon: rvolosatovs created PR review comment:

Shouldn't this case be merged with the one above?
I would expect the transmit future to resolve to the same error

Wasmtime GitHub notifications bot (Jun 10 2026 at 08:43):

:memo: vados-cosmonic submitted PR review.

Wasmtime GitHub notifications bot (Jun 10 2026 at 08:43):

:speech_balloon: vados-cosmonic created PR review comment:

Ah good point, yes -- we can move the transmit expect out

Wasmtime GitHub notifications bot (Jun 10 2026 at 08:45):

vados-cosmonic updated PR #13606.

Wasmtime GitHub notifications bot (Jun 10 2026 at 08:45):

:memo: vados-cosmonic submitted PR review.

Wasmtime GitHub notifications bot (Jun 10 2026 at 08:45):

:speech_balloon: vados-cosmonic created PR review comment:

OK, updated!

Wasmtime GitHub notifications bot (Jun 10 2026 at 08:48):

vados-cosmonic updated PR #13606.

Wasmtime GitHub notifications bot (Jun 10 2026 at 08:50):

vados-cosmonic updated PR #13606.

Wasmtime GitHub notifications bot (Jun 10 2026 at 08:52):

vados-cosmonic updated PR #13606.

Wasmtime GitHub notifications bot (Jun 10 2026 at 15:00):

:thumbs_up: alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Jun 10 2026 at 15:00):

alexcrichton added PR #13606 fix(tests): loosen p3 outbound content length error conditions to the merge queue.

Wasmtime GitHub notifications bot (Jun 10 2026 at 15:26):

:check: alexcrichton merged PR #13606.

Wasmtime GitHub notifications bot (Jun 10 2026 at 15:26):

alexcrichton removed PR #13606 fix(tests): loosen p3 outbound content length error conditions from the merge queue.

Last updated: Jul 29 2026 at 05:03 UTC