Stream: git-wasmtime

Topic: wasmtime / PR #13533 Make component-model-async feature n...

Wasmtime GitHub notifications bot (Jun 02 2026 at 02:27):

alexcrichton opened PR #13533 from alexcrichton:async-nostd to bytecodealliance:main:

This commit goes through the remaining bits of Wasmtime's
component-model-async feature and gets everything compiling with
no_std targets. The notable changes here are:

• Two Mutexes were replaced with a new custom TryMutex type. Usage
  panics on contention because contention should not be possible in the
  current architecture.

• TLS has been extended in the custom API to take an index of which
  TLS slot to access. Notably Wasmtime now requires two TLS slots
  instead of one.

Note: this is currently rebased on https://github.com/bytecodealliance/wasmtime/pull/13532

Wasmtime GitHub notifications bot (Jun 02 2026 at 02:27):

alexcrichton requested pchickey for a review on PR #13533.

Wasmtime GitHub notifications bot (Jun 02 2026 at 02:27):

alexcrichton requested wasmtime-wasi-reviewers for a review on PR #13533.

Wasmtime GitHub notifications bot (Jun 02 2026 at 02:27):

alexcrichton requested wasmtime-core-reviewers for a review on PR #13533.

Wasmtime GitHub notifications bot (Jun 02 2026 at 02:27):

alexcrichton requested fitzgen for a review on PR #13533.

Wasmtime GitHub notifications bot (Jun 02 2026 at 02:27):

alexcrichton requested wasmtime-default-reviewers for a review on PR #13533.

Wasmtime GitHub notifications bot (Jun 02 2026 at 06:16):

github-actions[bot] added the label wasi on PR #13533.

Wasmtime GitHub notifications bot (Jun 02 2026 at 06:16):

github-actions[bot] added the label wasmtime:api on PR #13533.

Wasmtime GitHub notifications bot (Jun 02 2026 at 14:47):

alexcrichton updated PR #13533.

Wasmtime GitHub notifications bot (Jun 02 2026 at 14:58):

alexcrichton updated PR #13533.

Wasmtime GitHub notifications bot (Jun 02 2026 at 16:29):

alexcrichton updated PR #13533.

Wasmtime GitHub notifications bot (Jun 02 2026 at 16:37):

alexcrichton edited PR #13533:

This commit goes through the remaining bits of Wasmtime's
component-model-async feature and gets everything compiling with
no_std targets. The notable changes here are:

• Two Mutexes were replaced with a new custom TryMutex type. Usage
  panics on contention because contention should not be possible in the
  current architecture.

• TLS has been extended in the custom API to take an index of which
  TLS slot to access. Notably Wasmtime now requires two TLS slots
  instead of one.

~~Note: this is currently rebased on https://github.com/bytecodealliance/wasmtime/pull/13532~~

Wasmtime GitHub notifications bot (Jun 02 2026 at 19:25):

:thumbs_up: fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Jun 02 2026 at 19:25):

:speech_balloon: fitzgen created PR review comment:

Maybe this should return a Result<TryMutexGuard> and bail_bug! on contention?

Wasmtime GitHub notifications bot (Jun 02 2026 at 21:00):

alexcrichton updated PR #13533.

Wasmtime GitHub notifications bot (Jun 02 2026 at 21:01):

:memo: alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Jun 02 2026 at 21:01):

:speech_balloon: alexcrichton created PR review comment:

I liked this idea, then realized I should also be adding at least a simple smoke test for this type, then realized that bail_bug! would make this more difficult to test. Given that I think this'll stay as-is as I think it might still be a useful primitive elsewhere for "just make this thing Sync and/or `"just make this thing mutable" in cases where contention may or may not be fatal.

Wasmtime GitHub notifications bot (Jun 02 2026 at 21:01):

alexcrichton has enabled auto merge for PR #13533.

Wasmtime GitHub notifications bot (Jun 02 2026 at 21:23):

alexcrichton added PR #13533 Make component-model-async feature no_std-compatible to the merge queue.

Wasmtime GitHub notifications bot (Jun 02 2026 at 21:48):

:check: alexcrichton merged PR #13533.

Wasmtime GitHub notifications bot (Jun 02 2026 at 21:48):

alexcrichton removed PR #13533 Make component-model-async feature no_std-compatible from the merge queue.

Last updated: Jul 29 2026 at 05:03 UTC