Wasmtime GitHub notifications bot (Mar 18 2020 at 16:46): Wasmtime GitHub notifications bot (Mar 18 2020 at 16:46):sunfishcode requested alexcrichton for a review on PR #1353.
Wasmtime GitHub notifications bot (Mar 18 2020 at 16:46):sunfishcode opened PR #1353 from sandboxing-docs to master:
Following up on #1272, this adds some high-level sandboxing documentation.
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Mar 18 2020 at 16:48):bjorn3 submitted PR Review.
Wasmtime GitHub notifications bot (Mar 18 2020 at 16:48):bjorn3 submitted PR Review.
Wasmtime GitHub notifications bot (Mar 18 2020 at 16:48):bjorn3 created PR Review Comment:
- Pointers, in source languages which have them, are compiled to offsets
Wasmtime GitHub notifications bot (Mar 18 2020 at 17:37):fitzgen submitted PR Review.
Wasmtime GitHub notifications bot (Mar 18 2020 at 17:37):fitzgen created PR Review Comment:
If untrusted code is allowed to print text which is displayed to a terminal, it may
Wasmtime GitHub notifications bot (Mar 18 2020 at 17:37):fitzgen submitted PR Review.
Wasmtime GitHub notifications bot (Mar 18 2020 at 17:40):alexcrichton submitted PR Review.
Wasmtime GitHub notifications bot (Mar 18 2020 at 17:44):sunfishcode updated PR #1353 from sandboxing-docs to master:
Following up on #1272, this adds some high-level sandboxing documentation.
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Mar 18 2020 at 17:45):sunfishcode updated PR #1353 from sandboxing-docs to master:
Following up on #1272, this adds some high-level sandboxing documentation.
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Mar 18 2020 at 18:12):sunfishcode updated PR #1353 from sandboxing-docs to master:
Following up on #1272, this adds some high-level sandboxing documentation.
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Mar 18 2020 at 18:36):sunfishcode updated PR #1353 from sandboxing-docs to master:
Following up on #1272, this adds some high-level sandboxing documentation.
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Mar 18 2020 at 18:43):sunfishcode updated PR #1353 from sandboxing-docs to master:
Following up on #1272, this adds some high-level sandboxing documentation.
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Mar 18 2020 at 19:42):sunfishcode merged PR #1353.
Last updated: Dec 23 2024 at 13:07 UTC