Stream: git-wasmtime

Topic: wasmtime / PR #13527 Cranelift: Remove the `icmp_imm` ins...

Wasmtime GitHub notifications bot (Jun 01 2026 at 19:51):

fitzgen opened PR #13527 from fitzgen:remove-icmp-imm to bytecodealliance:main:

Instead of icmp_imm we just use a normal iconst and normal icmp.

Adds a .inst_builder_imm_method(true) method to the instruction builder in the meta crate. When set, this makes the meta crate generate an <inst>_imm method on InstructionBuilder. This convenience method means that CLIF producers using existing the InstructionBuilder::icmp_imm method will keep working. This infrastructure will be used more in upcoming commits.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Jun 01 2026 at 19:51):

fitzgen requested cfallin for a review on PR #13527.

Wasmtime GitHub notifications bot (Jun 01 2026 at 19:51):

fitzgen requested wasmtime-compiler-reviewers for a review on PR #13527.

Wasmtime GitHub notifications bot (Jun 01 2026 at 19:51):

fitzgen requested wasmtime-core-reviewers for a review on PR #13527.

Wasmtime GitHub notifications bot (Jun 01 2026 at 20:18):

:thumbs_up: cfallin submitted PR review:

Looks reasonable enough, thanks! Some thoughts below.

Wasmtime GitHub notifications bot (Jun 01 2026 at 20:18):

:speech_balloon: cfallin created PR review comment:

Now that we're generating these helpers automatically, I wonder if it would make sense to have _imm_u and _imm_s variants? And maybe newtype the immediates (so we have SImm128 / UImm128 etc)? I guess my overall thought is that "historical semantics" carry some weight as far as back-compat goes but not too much, and as long as we're cleaning up we may as well clean up the interface too...

Wasmtime GitHub notifications bot (Jun 01 2026 at 20:59):

:memo: fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Jun 01 2026 at 20:59):

:speech_balloon: fitzgen created PR review comment:

I think this makes sense medium/long term, but my immediate term goals are to remove the instructions without breaking embedders as much as possible. I can spin this off into a new follow up issue if that's alright with you.

Wasmtime GitHub notifications bot (Jun 01 2026 at 21:00):

:memo: cfallin submitted PR review.

Wasmtime GitHub notifications bot (Jun 01 2026 at 21:00):

:speech_balloon: cfallin created PR review comment:

Sounds good!

Wasmtime GitHub notifications bot (Jun 01 2026 at 21:42):

:memo: fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Jun 01 2026 at 21:42):

:speech_balloon: fitzgen created PR review comment:

Filed https://github.com/bytecodealliance/wasmtime/issues/13529

Wasmtime GitHub notifications bot (Jun 01 2026 at 23:04):

fitzgen updated PR #13527.

Wasmtime GitHub notifications bot (Jun 01 2026 at 23:05):

fitzgen has enabled auto merge for PR #13527.

Wasmtime GitHub notifications bot (Jun 01 2026 at 23:23):

fitzgen updated PR #13527.

Wasmtime GitHub notifications bot (Jun 01 2026 at 23:38):

fitzgen added PR #13527 Cranelift: Remove the icmp_imm instruction to the merge queue.

Wasmtime GitHub notifications bot (Jun 02 2026 at 00:04):

github-merge-queue[bot] removed PR #13527 Cranelift: Remove the icmp_imm instruction from the merge queue.

Wasmtime GitHub notifications bot (Jun 02 2026 at 00:08):

alexcrichton added PR #13527 Cranelift: Remove the icmp_imm instruction to the merge queue.

Wasmtime GitHub notifications bot (Jun 02 2026 at 00:33):

:check: alexcrichton merged PR #13527.

Wasmtime GitHub notifications bot (Jun 02 2026 at 00:33):

alexcrichton removed PR #13527 Cranelift: Remove the icmp_imm instruction from the merge queue.

Last updated: Jul 29 2026 at 05:03 UTC